feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Privatize BaseHoverHandler::decorateToolTip()

Browse Source 
Never overridden, and does not look safe to invoke more than once.

Change-Id: If5f3830f3fbf26badb6335443defd628c05cf65a
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2019-07-22 15:17:47 +02:00
parent c52c857076
commit e23664cc42
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cpptools/cpphoverhandler.cpp
View File

@@ -62,7 +62,7 @@ void CppHoverHandler::identifyMatch(TextEditorWidget *editorWidget, int pos, Rep
const QSharedPointer<CppElement> &cppElement = evaluator.cppElement(); const QSharedPointer<CppElement> &cppElement = evaluator.cppElement();
const QStringList candidates = cppElement->helpIdCandidates; const QStringList candidates = cppElement->helpIdCandidates;
const HelpItem helpItem(candidates + fallback, cppElement->helpMark, cppElement->helpCategory); const HelpItem helpItem(candidates + fallback, cppElement->helpMark, cppElement->helpCategory);
setLastHelpItemIdentified(helpItem); // tool tip appended by decorateToolTip setLastHelpItemIdentified(helpItem); // tool tip appended by BaseHoverHandler::decorateToolTip
if (!helpItem.isValid()) if (!helpItem.isValid())
tip += cppElement->tooltip; tip += cppElement->tooltip;
} else { } else {

2
src/plugins/texteditor/basehoverhandler.h
View File

@@ -80,11 +80,11 @@ protected:
// Utils::ExecuteOnDestruction reportPriority([this, report](){ report(priority()); }); // Utils::ExecuteOnDestruction reportPriority([this, report](){ report(priority()); });
// at the beginning of an implementation to ensure this in any case. // at the beginning of an implementation to ensure this in any case.
virtual void identifyMatch(TextEditorWidget *editorWidget, int pos, ReportPriority report); virtual void identifyMatch(TextEditorWidget *editorWidget, int pos, ReportPriority report);
virtual void decorateToolTip();
virtual void operateTooltip(TextEditorWidget *editorWidget, const QPoint &point); virtual void operateTooltip(TextEditorWidget *editorWidget, const QPoint &point);
private: private:
void process(TextEditorWidget *widget, int pos, ReportPriority report); void process(TextEditorWidget *widget, int pos, ReportPriority report);
void decorateToolTip();
QString m_toolTip; QString m_toolTip;
Core::HelpItem m_lastHelpItemIdentified; Core::HelpItem m_lastHelpItemIdentified;