feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: prefilter refactor markers before painting

Browse Source 
This prevents calculating the block bounding rect for blocks outside of
the cliprect.

Change-Id: I416f1e6f71ae7e87fcc208f3eb3eb69300c9a1f8
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2023-06-09 11:55:25 +02:00
parent f782399789
commit e24be95601
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/texteditor/refactoroverlay.cpp
View File

@@ -24,14 +24,21 @@ RefactorOverlay::RefactorOverlay(TextEditor::TextEditorWidget *editor) :
void RefactorOverlay::paint(QPainter *painter, const QRect &clip)
{
const auto firstBlock = m_editor->blockForVerticalOffset(clip.top());
const auto lastBlock = m_editor->blockForVerticalOffset(clip.bottom());
m_maxWidth = 0;
for (auto &marker : std::as_const(m_markers)) {
for (const RefactorMarker &marker : std::as_const(m_markers)) {
const int markerBlockNumber = marker.cursor.block().blockNumber();
if (markerBlockNumber < firstBlock.blockNumber())
continue;
if (markerBlockNumber > lastBlock.blockNumber())
continue;
paintMarker(marker, painter, clip);
}
if (auto documentLayout = qobject_cast<TextDocumentLayout*>(m_editor->document()->documentLayout()))
documentLayout->setRequiredWidth(m_maxWidth);
}
RefactorMarker RefactorOverlay::markerAt(const QPoint &pos) const