Provide a default implementation for doDeviceSetup / stopDeviceSetup

Change-Id: I9f4e15f98039315ddcdd4f40fb6d0802b94da87a
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>

src/plugins/boot2qt/qdbmakedefaultappservice.h

@@ -45,8 +45,6 @@ private:
     void handleProcessFinished(const QString &error);
 
     bool isDeploymentNecessary() const final { return true; }
-    void doDeviceSetup() final { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() final { handleDeviceSetupDone(false); }
 
     void doDeploy() final;
     void stopDeployment() final;

src/plugins/boot2qt/qdbstopapplicationservice.h

@@ -47,8 +47,6 @@ private:
     void handleAppendMessage(const QString &message, Utils::OutputFormat format);
 
     bool isDeploymentNecessary() const final { return true; }
-    void doDeviceSetup() final { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() final { handleDeviceSetupDone(false); }
 
     void doDeploy() final;
     void stopDeployment() final;

src/plugins/remotelinux/abstractremotelinuxdeployservice.h

@@ -102,16 +102,16 @@ protected:
     void handleDeviceSetupDone(bool success);
     void handleDeploymentDone();
 
+    // Should do things needed *before* connecting. Call default implementation afterwards.
+    virtual void doDeviceSetup() { handleDeviceSetupDone(true); }
+    virtual void stopDeviceSetup() { handleDeviceSetupDone(false); }
+
 private:
     void handleConnected();
     void handleConnectionFailure();
 
     virtual bool isDeploymentNecessary() const = 0;
 
-    // Should do things needed *before* connecting. Call handleDeviceSetupDone() afterwards.
-    virtual void doDeviceSetup() = 0;
-    virtual void stopDeviceSetup() = 0;
-
     virtual void doDeploy() = 0;
     virtual void stopDeployment() = 0;
 

src/plugins/remotelinux/abstractuploadandinstallpackageservice.cpp

@@ -89,15 +89,13 @@ bool AbstractUploadAndInstallPackageService::isDeploymentNecessary() const
 void AbstractUploadAndInstallPackageService::doDeviceSetup()
 {
     QTC_ASSERT(d->state == Inactive, return);
-
+    AbstractRemoteLinuxDeployService::doDeviceSetup();
-    handleDeviceSetupDone(true);
 }
 
 void AbstractUploadAndInstallPackageService::stopDeviceSetup()
 {
     QTC_ASSERT(d->state == Inactive, return);
-
+    AbstractRemoteLinuxDeployService::stopDeviceSetup();
-    handleDeviceSetupDone(false);
 }
 
 void AbstractUploadAndInstallPackageService::doDeploy()

src/plugins/remotelinux/genericdirectuploadservice.cpp

@@ -118,15 +118,13 @@ bool GenericDirectUploadService::isDeploymentNecessary() const
 void GenericDirectUploadService::doDeviceSetup()
 {
     QTC_ASSERT(d->state == Inactive, return);
-
+    AbstractRemoteLinuxDeployService::doDeviceSetup();
-    handleDeviceSetupDone(true);
 }
 
 void GenericDirectUploadService::stopDeviceSetup()
 {
     QTC_ASSERT(d->state == Inactive, return);
-
+    AbstractRemoteLinuxDeployService::stopDeviceSetup();
-    handleDeviceSetupDone(false);
 }
 
 void GenericDirectUploadService::doDeploy()

src/plugins/remotelinux/genericdirectuploadservice.h

@@ -53,7 +53,7 @@ public:
     void setIncrementalDeployment(IncrementalDeployment incremental);
     void setIgnoreMissingFiles(bool ignoreMissingFiles);
 
-  protected:
+protected:
     bool isDeploymentNecessary() const override;
 
     void doDeviceSetup() override;

src/plugins/remotelinux/remotelinuxcheckforfreediskspaceservice.h

@@ -46,8 +46,6 @@ private:
     void handleProcessFinished();
 
     bool isDeploymentNecessary() const override { return true; }
-    void doDeviceSetup() override { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() override { handleDeviceSetupDone(false); }
 
     CheckResult isDeploymentPossible() const override;
     void doDeploy() override;

src/plugins/remotelinux/remotelinuxcustomcommanddeployservice.h

@@ -44,8 +44,6 @@ public:
     CheckResult isDeploymentPossible() const override;
 
 protected:
-    void doDeviceSetup() override { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() override { handleDeviceSetupDone(false); }
     void doDeploy() override;
     void stopDeployment() override;
 

src/plugins/remotelinux/remotelinuxkillappservice.h

@@ -44,8 +44,6 @@ private:
     void handleProcessFinished();
 
     bool isDeploymentNecessary() const override;
-    void doDeviceSetup() override { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() override { handleDeviceSetupDone(false); }
 
     void doDeploy() override;
     void stopDeployment() override;

src/plugins/remotelinux/rsyncdeploystep.cpp

@@ -57,9 +57,6 @@ public:
 private:
     bool isDeploymentNecessary() const override;
 
-    void doDeviceSetup() override { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() override { handleDeviceSetupDone(false); };
-
     void doDeploy() override;
     void stopDeployment() override { setFinished(); };