Tracing: Use override consistently

clang-tidy fixes from modernize-use-override check.

Change-Id: I6ddeef87244c2242945dd91e29ef0cd8bb9fe636
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-07 15:13:25 +02:00
parent 1923d38e5b
commit e30939fe4d
10 changed files with 18 additions and 18 deletions

View File

@@ -47,7 +47,7 @@ class TRACING_EXPORT TimelineAbstractRenderer : public QQuickItem
public: public:
TimelineAbstractRenderer(QQuickItem *parent = 0); TimelineAbstractRenderer(QQuickItem *parent = 0);
~TimelineAbstractRenderer(); ~TimelineAbstractRenderer() override;
bool selectionLocked() const; bool selectionLocked() const;
int selectedItem() const; int selectedItem() const;
@@ -81,7 +81,7 @@ public:
void setRowHeightsDirty(); void setRowHeightsDirty();
protected: protected:
QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData); QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
class TimelineAbstractRendererPrivate; class TimelineAbstractRendererPrivate;
TimelineAbstractRenderer(TimelineAbstractRendererPrivate &dd, QQuickItem *parent = 0); TimelineAbstractRenderer(TimelineAbstractRendererPrivate &dd, QQuickItem *parent = 0);

View File

@@ -44,8 +44,8 @@ public:
QColor selectionColor() const; QColor selectionColor() const;
void setSelectionColor(QColor selectionColor); void setSelectionColor(QColor selectionColor);
QSGMaterialType *type() const; QSGMaterialType *type() const override;
QSGMaterialShader *createShader() const; QSGMaterialShader *createShader() const override;
private: private:
QVector2D m_scale; QVector2D m_scale;
@@ -95,7 +95,7 @@ public:
static const TimelineItemsRenderPass *instance(); static const TimelineItemsRenderPass *instance();
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState, State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *state, int firstIndex, int lastIndex, bool stateChanged, State *state, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const; float spacing) const override;
protected: protected:
TimelineItemsRenderPass(); TimelineItemsRenderPass();
}; };

View File

@@ -53,7 +53,7 @@ public:
class TimelineModelPrivate; class TimelineModelPrivate;
TimelineModel(TimelineModelAggregator *parent); TimelineModel(TimelineModelAggregator *parent);
~TimelineModel(); ~TimelineModel() override;
// Methods implemented by the abstract model itself // Methods implemented by the abstract model itself
bool isEmpty() const; bool isEmpty() const;

View File

@@ -38,7 +38,7 @@ class TRACING_EXPORT TimelineModelAggregator : public QObject
Q_PROPERTY(Timeline::TimelineNotesModel *notes READ notes CONSTANT) Q_PROPERTY(Timeline::TimelineNotesModel *notes READ notes CONSTANT)
public: public:
TimelineModelAggregator(TimelineNotesModel *notes = nullptr, QObject *parent = nullptr); TimelineModelAggregator(TimelineNotesModel *notes = nullptr, QObject *parent = nullptr);
~TimelineModelAggregator(); ~TimelineModelAggregator() override;
int height() const; int height() const;
int generateModelId(); int generateModelId();

View File

@@ -35,7 +35,7 @@ class TRACING_EXPORT TimelineNotesModel : public QObject
Q_PROPERTY(int count READ count NOTIFY changed) Q_PROPERTY(int count READ count NOTIFY changed)
public: public:
TimelineNotesModel(QObject *parent = 0); TimelineNotesModel(QObject *parent = 0);
~TimelineNotesModel(); ~TimelineNotesModel() override;
int count() const; int count() const;
void addTimelineModel(const TimelineModel *timelineModel); void addTimelineModel(const TimelineModel *timelineModel);

View File

@@ -37,7 +37,7 @@ public:
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState, State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *oldState, int firstIndex, int lastIndex, bool stateChanged, State *oldState, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const; float spacing) const override;
private: private:
TimelineNotesRenderPass(); TimelineNotesRenderPass();

View File

@@ -35,7 +35,7 @@ public:
TimelineOverviewRenderer(QQuickItem *parent = 0); TimelineOverviewRenderer(QQuickItem *parent = 0);
protected: protected:
virtual QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData); QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
class TimelineOverviewRendererPrivate; class TimelineOverviewRendererPrivate;
Q_DECLARE_PRIVATE(TimelineOverviewRenderer) Q_DECLARE_PRIVATE(TimelineOverviewRenderer)

View File

@@ -48,12 +48,12 @@ public:
Q_INVOKABLE void clearData(); Q_INVOKABLE void clearData();
protected: protected:
virtual QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData); QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
virtual void mousePressEvent(QMouseEvent *event); void mousePressEvent(QMouseEvent *event) override;
virtual void mouseReleaseEvent(QMouseEvent *event); void mouseReleaseEvent(QMouseEvent *event) override;
virtual void mouseMoveEvent(QMouseEvent *event); void mouseMoveEvent(QMouseEvent *event) override;
virtual void hoverMoveEvent(QHoverEvent *event); void hoverMoveEvent(QHoverEvent *event) override;
virtual void wheelEvent(QWheelEvent *event); void wheelEvent(QWheelEvent *event) override;
private: private:
class TimelineRendererPrivate; class TimelineRendererPrivate;

View File

@@ -38,7 +38,7 @@ public:
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState, State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *state, int firstIndex, int lastIndex, bool stateChanged, State *state, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const; float spacing) const override;
protected: protected:
TimelineSelectionRenderPass(); TimelineSelectionRenderPass();

View File

@@ -49,7 +49,7 @@ public:
typedef std::function<void(const QString &)> ErrorHandler; typedef std::function<void(const QString &)> ErrorHandler;
explicit TimelineTraceManager(QObject *parent = nullptr); explicit TimelineTraceManager(QObject *parent = nullptr);
~TimelineTraceManager(); ~TimelineTraceManager() override;
qint64 traceStart() const; qint64 traceStart() const;
qint64 traceEnd() const; qint64 traceEnd() const;