feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Tracing: Use override consistently

Browse Source 
clang-tidy fixes from modernize-use-override check.

Change-Id: I6ddeef87244c2242945dd91e29ef0cd8bb9fe636
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-07 15:13:25 +02:00
parent 1923d38e5b
commit e30939fe4d
10 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/tracing/timelineabstractrenderer.h
View File

@@ -47,7 +47,7 @@ class TRACING_EXPORT TimelineAbstractRenderer : public QQuickItem
public:
TimelineAbstractRenderer(QQuickItem *parent = 0);
~TimelineAbstractRenderer();
~TimelineAbstractRenderer() override;
bool selectionLocked() const;
int selectedItem() const;
@@ -81,7 +81,7 @@ public:
void setRowHeightsDirty();
protected:
QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData);
QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
class TimelineAbstractRendererPrivate;
TimelineAbstractRenderer(TimelineAbstractRendererPrivate &dd, QQuickItem *parent = 0);

6
src/libs/tracing/timelineitemsrenderpass.h
View File

@@ -44,8 +44,8 @@ public:
QColor selectionColor() const;
void setSelectionColor(QColor selectionColor);
QSGMaterialType *type() const;
QSGMaterialShader *createShader() const;
QSGMaterialType *type() const override;
QSGMaterialShader *createShader() const override;
private:
QVector2D m_scale;
@@ -95,7 +95,7 @@ public:
static const TimelineItemsRenderPass *instance();
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *state, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const;
float spacing) const override;
protected:
TimelineItemsRenderPass();
};

2
src/libs/tracing/timelinemodel.h
View File

@@ -53,7 +53,7 @@ public:
class TimelineModelPrivate;
TimelineModel(TimelineModelAggregator *parent);
~TimelineModel();
~TimelineModel() override;
// Methods implemented by the abstract model itself
bool isEmpty() const;

2
src/libs/tracing/timelinemodelaggregator.h
View File

@@ -38,7 +38,7 @@ class TRACING_EXPORT TimelineModelAggregator : public QObject
Q_PROPERTY(Timeline::TimelineNotesModel *notes READ notes CONSTANT)
public:
TimelineModelAggregator(TimelineNotesModel *notes = nullptr, QObject *parent = nullptr);
~TimelineModelAggregator();
~TimelineModelAggregator() override;
int height() const;
int generateModelId();

2
src/libs/tracing/timelinenotesmodel.h
View File

@@ -35,7 +35,7 @@ class TRACING_EXPORT TimelineNotesModel : public QObject
Q_PROPERTY(int count READ count NOTIFY changed)
public:
TimelineNotesModel(QObject *parent = 0);
~TimelineNotesModel();
~TimelineNotesModel() override;
int count() const;
void addTimelineModel(const TimelineModel *timelineModel);

2
src/libs/tracing/timelinenotesrenderpass.h
View File

@@ -37,7 +37,7 @@ public:
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *oldState, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const;
float spacing) const override;
private:
TimelineNotesRenderPass();

2
src/libs/tracing/timelineoverviewrenderer.h
View File

@@ -35,7 +35,7 @@ public:
TimelineOverviewRenderer(QQuickItem *parent = 0);
protected:
virtual QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData);
QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
class TimelineOverviewRendererPrivate;
Q_DECLARE_PRIVATE(TimelineOverviewRenderer)

12
src/libs/tracing/timelinerenderer.h
View File

@@ -48,12 +48,12 @@ public:
Q_INVOKABLE void clearData();
protected:
virtual QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData);
virtual void mousePressEvent(QMouseEvent *event);
virtual void mouseReleaseEvent(QMouseEvent *event);
virtual void mouseMoveEvent(QMouseEvent *event);
virtual void hoverMoveEvent(QHoverEvent *event);
virtual void wheelEvent(QWheelEvent *event);
QSGNode *updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData *updatePaintNodeData) override;
void mousePressEvent(QMouseEvent *event) override;
void mouseReleaseEvent(QMouseEvent *event) override;
void mouseMoveEvent(QMouseEvent *event) override;
void hoverMoveEvent(QHoverEvent *event) override;
void wheelEvent(QWheelEvent *event) override;
private:
class TimelineRendererPrivate;

2
src/libs/tracing/timelineselectionrenderpass.h
View File

@@ -38,7 +38,7 @@ public:
State *update(const TimelineAbstractRenderer *renderer, const TimelineRenderState *parentState,
State *state, int firstIndex, int lastIndex, bool stateChanged,
float spacing) const;
float spacing) const override;
protected:
TimelineSelectionRenderPass();

2
src/libs/tracing/timelinetracemanager.h
View File

@@ -49,7 +49,7 @@ public:
typedef std::function<void(const QString &)> ErrorHandler;
explicit TimelineTraceManager(QObject *parent = nullptr);
~TimelineTraceManager();
~TimelineTraceManager() override;
qint64 traceStart() const;
qint64 traceEnd() const;