feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Revert "Completion: Apply perfect match whenever not invoked explicitly"

Browse Source 
This reverts commit 4959f53d2c.

It seems that usability is better when upon a perfect match the completion
popup stays when triggered either explicitly or by an activation character.
After all, in general one should need to type something else (semicolon,
parenthesis, etc.) anyway for the case of an activation character.

This is also consistent with the behavior from previous releases.

Change-Id: I1d50230affb1d0642f8f8bfd5cbac69dc52e44bd
Reviewed-on: http://codereview.qt.nokia.com/536
Reviewed-by: Thorbjørn Lindeijer <thorbjorn@lindeijer.nl>
This commit is contained in:
Leandro Melo
2011-06-21 11:06:03 +02:00
committed by Leandro T. C. Melo
parent 44818eb34e
commit e31accb848
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/texteditor/codeassist/genericproposalwidget.cpp
View File

@@ -425,7 +425,7 @@ bool GenericProposalWidget::updateAndCheck(const QString &prefix)
if (!prefix.isEmpty())
m_d->m_model->filter(prefix);
if (m_d->m_model->size() == 0
|| (m_d->m_reason != ExplicitlyInvoked && hasMatch(prefix, m_d->m_model))) {
|| (m_d->m_reason == IdleEditor && hasMatch(prefix, m_d->m_model))) {
abort();
return false;
}