feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Remove GDB specific access test in generic pointer code

Browse Source 
The field checked for does not even exists in lldb.SBValue.

Change-Id: I062ccf62da2e2ea3f011d0b841cba0e87f7c6fa9
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-04-13 15:52:07 +02:00
parent c24640bae1
commit e33da6a6b3
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
share/qtcreator/debugger/dumper.py
View File

@@ -1057,10 +1057,18 @@ class DumperBase:
innerType = value.type.target().unqualified() innerType = value.type.target().unqualified()
innerTypeName = str(innerType) innerTypeName = str(innerType)
goodPointer = False
try: try:
target = value.dereference() target = value.dereference()
target.is_optimized_out # Access test. str(target) # Dummy access.
if self.isLldb and target.GetError().Fail():
pass
else:
goodPointer = True
except: except:
pass
if not goodPointer:
# Failure to dereference a pointer should at least # Failure to dereference a pointer should at least
# show the value of a pointer. # show the value of a pointer.
self.putValue(self.cleanAddress(value)) self.putValue(self.cleanAddress(value))
@@ -1128,7 +1136,6 @@ class DumperBase:
self.currentChildType = self.stripClassTag(innerTypeName) self.currentChildType = self.stripClassTag(innerTypeName)
self.putItem(value.dereference()) self.putItem(value.dereference())
self.currentChildType = savedCurrentChildType self.currentChildType = savedCurrentChildType
#self.putPointerValue(value)
self.putOriginalAddress(value) self.putOriginalAddress(value)
return return