diff --git a/src/plugins/qt4projectmanager/makestep.cpp b/src/plugins/qt4projectmanager/makestep.cpp index b411b7864bc..77ac9fdd12a 100644 --- a/src/plugins/qt4projectmanager/makestep.cpp +++ b/src/plugins/qt4projectmanager/makestep.cpp @@ -37,7 +37,6 @@ #include "qt4target.h" #include "qt4buildconfiguration.h" #include "qt4projectmanagerconstants.h" -#include "qtparser.h" #include #include @@ -45,6 +44,7 @@ #include #include #include +#include #include #include @@ -207,9 +207,9 @@ bool MakeStep::init() if (bc->qtVersion()) parser = bc->qtVersion()->createOutputParser(); if (parser) - parser->appendOutputParser(new QtParser); + parser->appendOutputParser(new QtSupport::QtParser); else - parser = new QtParser; + parser = new QtSupport::QtParser; if (toolchain) parser->appendOutputParser(toolchain->outputParser()); diff --git a/src/plugins/qt4projectmanager/qt4projectmanager.pro b/src/plugins/qt4projectmanager/qt4projectmanager.pro index dc8e751430e..d024c254569 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanager.pro +++ b/src/plugins/qt4projectmanager/qt4projectmanager.pro @@ -6,7 +6,6 @@ include(../../qtcreatorplugin.pri) include(qt4projectmanager_dependencies.pri) HEADERS += \ - qtparser.h \ qt4projectmanagerplugin.h \ qt4projectmanager.h \ qt4project.h \ @@ -72,7 +71,6 @@ HEADERS += \ qt4basetargetfactory.h SOURCES += qt4projectmanagerplugin.cpp \ - qtparser.cpp \ qt4projectmanager.cpp \ qt4project.cpp \ qt4nodes.cpp \ diff --git a/src/plugins/qt4projectmanager/qt4projectmanagerplugin.h b/src/plugins/qt4projectmanager/qt4projectmanagerplugin.h index d2b702a6d4c..af634fc5373 100644 --- a/src/plugins/qt4projectmanager/qt4projectmanagerplugin.h +++ b/src/plugins/qt4projectmanager/qt4projectmanagerplugin.h @@ -74,11 +74,8 @@ private slots: #ifdef WITH_TESTS void testBasicProjectLoading(); // Test fails! - void testAbldOutputParsers_data(); void testAbldOutputParsers(); - void testQtOutputParser_data(); - void testQtOutputParser(); void testSbsV2OutputParsers_data(); void testSbsV2OutputParsers(); void testRvctOutputParser_data(); diff --git a/src/plugins/qt4projectmanager/qtparser.cpp b/src/plugins/qtsupport/qtparser.cpp similarity index 96% rename from src/plugins/qt4projectmanager/qtparser.cpp rename to src/plugins/qtsupport/qtparser.cpp index 5af65d36cec..1146d8a9e75 100644 --- a/src/plugins/qt4projectmanager/qtparser.cpp +++ b/src/plugins/qtsupport/qtparser.cpp @@ -31,14 +31,12 @@ **************************************************************************/ #include "qtparser.h" -#include "qt4projectmanagerconstants.h" #include #include #include -using namespace Qt4ProjectManager; -using namespace Qt4ProjectManager::Internal; +using namespace QtSupport; using ProjectExplorer::Task; namespace { @@ -79,14 +77,15 @@ void QtParser::stdError(const QString &line) #ifdef WITH_TESTS # include -# include "qt4projectmanagerplugin.h" +# include "qtsupportplugin.h" # include # include # include using namespace ProjectExplorer; +using namespace QtSupport::Internal; -void Qt4ProjectManagerPlugin::testQtOutputParser_data() +void QtSupportPlugin::testQtOutputParser_data() { QTest::addColumn("input"); QTest::addColumn("inputChannel"); @@ -141,7 +140,7 @@ void Qt4ProjectManagerPlugin::testQtOutputParser_data() << QString(); } -void Qt4ProjectManagerPlugin::testQtOutputParser() +void QtSupportPlugin::testQtOutputParser() { OutputParserTester testbench; testbench.appendOutputParser(new QtParser); diff --git a/src/plugins/qt4projectmanager/qtparser.h b/src/plugins/qtsupport/qtparser.h similarity index 92% rename from src/plugins/qt4projectmanager/qtparser.h rename to src/plugins/qtsupport/qtparser.h index b967899e460..55184787d29 100644 --- a/src/plugins/qt4projectmanager/qtparser.h +++ b/src/plugins/qtsupport/qtparser.h @@ -33,14 +33,14 @@ #ifndef QTPARSER_H #define QTPARSER_H +#include "qtsupport_global.h" #include -namespace Qt4ProjectManager { -namespace Internal { +namespace QtSupport { // Parser for Qt-specific utilities like moc, uic, etc. -class QtParser : public ProjectExplorer::IOutputParser +class QTSUPPORT_EXPORT QtParser : public ProjectExplorer::IOutputParser { Q_OBJECT @@ -52,7 +52,6 @@ private: QRegExp m_mocRegExp; }; -} // namesapce Internal } // namespace ProjectExplorer #endif // QTPARSER_H diff --git a/src/plugins/qtsupport/qtsupport.pro b/src/plugins/qtsupport/qtsupport.pro index 5c3484d0b08..a2f425465ea 100644 --- a/src/plugins/qtsupport/qtsupport.pro +++ b/src/plugins/qtsupport/qtsupport.pro @@ -21,6 +21,7 @@ HEADERS += \ debugginghelperbuildtask.h \ qtsupportconstants.h \ profilereader.h \ + qtparser.h SOURCES += \ qtsupportplugin.cpp \ @@ -34,6 +35,7 @@ SOURCES += \ qtoptionspage.cpp \ debugginghelperbuildtask.cpp \ profilereader.cpp \ + qtparser.cpp FORMS += \ showbuildlog.ui \ diff --git a/src/plugins/qtsupport/qtsupportplugin.h b/src/plugins/qtsupport/qtsupportplugin.h index 15659040afc..5423d9125e1 100644 --- a/src/plugins/qtsupport/qtsupportplugin.h +++ b/src/plugins/qtsupport/qtsupportplugin.h @@ -49,6 +49,12 @@ public: ~QtSupportPlugin(); bool initialize(const QStringList &arguments, QString *error_message); void extensionsInitialized(); + +private slots: +#ifdef WITH_TESTS + void testQtOutputParser_data(); + void testQtOutputParser(); +#endif }; } // namespace Internal