forked from qt-creator/qt-creator
Fix dead stores in the debugger plugin
Found via the clang-static-analyzer Change-Id: Ic461a8c369bef60081f7c2dfd9d6a778c64dbda0 Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
@@ -1879,7 +1879,6 @@ void DebuggerEngine::validateExecutable(DebuggerRunParameters *sp)
|
|||||||
switch (sp->toolChainAbi.binaryFormat()) {
|
switch (sp->toolChainAbi.binaryFormat()) {
|
||||||
case Abi::PEFormat: {
|
case Abi::PEFormat: {
|
||||||
if (sp->masterEngineType != CdbEngineType) {
|
if (sp->masterEngineType != CdbEngineType) {
|
||||||
warnOnInappropriateDebugger = true;
|
|
||||||
detailedWarning = tr(
|
detailedWarning = tr(
|
||||||
"The inferior is in the Portable Executable format.\n"
|
"The inferior is in the Portable Executable format.\n"
|
||||||
"Selecting CDB as debugger would improve the debugging "
|
"Selecting CDB as debugger would improve the debugging "
|
||||||
@@ -1903,7 +1902,6 @@ void DebuggerEngine::validateExecutable(DebuggerRunParameters *sp)
|
|||||||
}
|
}
|
||||||
case Abi::ElfFormat: {
|
case Abi::ElfFormat: {
|
||||||
if (sp->masterEngineType == CdbEngineType) {
|
if (sp->masterEngineType == CdbEngineType) {
|
||||||
warnOnInappropriateDebugger = true;
|
|
||||||
detailedWarning = tr(
|
detailedWarning = tr(
|
||||||
"The inferior is in the ELF format.\n"
|
"The inferior is in the ELF format.\n"
|
||||||
"Selecting GDB or LLDB as debugger would improve the debugging "
|
"Selecting GDB or LLDB as debugger would improve the debugging "
|
||||||
|
|||||||
Reference in New Issue
Block a user