feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ShellCommand: De-virtualize runCommand()

Browse Source 
Add virtual postRunCommand() method, called
by the end of runCommand().

In this way the rest of the API of VcsCommand remains
an implementation detail.

Change-Id: Ia4149334bd39a1448266d2406e0987bee07a9c58
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-12 13:34:26 +02:00
parent 3de1fffbeb
commit e3da02248a
4 changed files with 14 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/utils/shellcommand.cpp
View File

@@ -219,6 +219,11 @@ void ShellCommand::addTask(QFuture<void> &future)
Q_UNUSED(future)
}
void ShellCommand::postRunCommand(const FilePath &workingDirectory)
{
Q_UNUSED(workingDirectory)
}
int ShellCommand::timeoutS() const
{
return std::accumulate(d->m_jobs.cbegin(), d->m_jobs.cend(), 0,
@@ -318,6 +323,7 @@ void ShellCommand::runCommand(QtcProcess &proc,
emit appendError(proc.exitMessage());
}
}
postRunCommand(dir);
}
void ShellCommand::runFullySynchronous(QtcProcess &process, const FilePath &workingDirectory)