feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Reduce usage of QStringRef::toString() in QmlJS/QmlJSTools.

Browse Source 
Change-Id: I9db2a0b21bf430d6f450e1e860a0c2a02272536f
Reviewed-by: Fawzi Mohamed <fawzi.mohamed@digia.com>
This commit is contained in:
Friedemann Kleint
2013-08-29 10:56:58 +02:00
parent 0c621dcdcf
commit e43e466b5b
5 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libs/qmljs/qmljscheck.cpp
View File

@@ -862,10 +862,11 @@ bool Check::visit(UiPublicMember *ast)
if (ast->type == UiPublicMember::Property) {
// check if the member type is valid
if (!ast->memberType.isEmpty()) {
const QString &name = ast->memberType.toString();
const QStringRef name = ast->memberType;
if (!name.isEmpty() && name.at(0).isLower()) {
if (!isValidBuiltinPropertyType(name))
addMessage(ErrInvalidPropertyType, ast->typeToken, name);
const QString nameS = name.toString();
if (!isValidBuiltinPropertyType(nameS))
addMessage(ErrInvalidPropertyType, ast->typeToken, nameS);
}
// warn about dubious use of var/variant