diff --git a/src/plugins/coreplugin/externaltool.cpp b/src/plugins/coreplugin/externaltool.cpp index 6dffaa0310b..2ef5e7e9ca5 100644 --- a/src/plugins/coreplugin/externaltool.cpp +++ b/src/plugins/coreplugin/externaltool.cpp @@ -51,7 +51,6 @@ using namespace Utils; using namespace Core::Internal; namespace Core { -namespace Internal { const char kExternalTool[] = "externaltool"; const char kId[] = "id"; @@ -331,7 +330,7 @@ static void localizedText(const QStringList &locales, QXmlStreamReader *reader, } } else { if (*currentLocale < 0 && currentText->isEmpty()) { - *currentText = QCoreApplication::translate("Core::Internal::ExternalTool", + *currentText = QCoreApplication::translate("Core::ExternalTool", reader->readElementText().toUtf8().constData(), ""); } else { @@ -721,6 +720,4 @@ void ExternalToolRunner::readStandardError() m_processOutput.append(output); } -} // namespace Internal - } // namespace Core diff --git a/src/plugins/coreplugin/externaltool.h b/src/plugins/coreplugin/externaltool.h index 38fc517bd2d..caec43258c1 100644 --- a/src/plugins/coreplugin/externaltool.h +++ b/src/plugins/coreplugin/externaltool.h @@ -25,6 +25,8 @@ #pragma once +#include + #include #include #include @@ -38,9 +40,8 @@ namespace Utils { class QtcProcess; } namespace Core { -namespace Internal { -class ExternalTool : public QObject +class CORE_EXPORT ExternalTool : public QObject { Q_OBJECT @@ -123,7 +124,7 @@ private: QSharedPointer m_presetTool; }; -class ExternalToolRunner : public QObject +class CORE_EXPORT ExternalToolRunner : public QObject { Q_OBJECT public: @@ -158,7 +159,6 @@ private: QString m_errorString; }; -} // Internal } // Core -Q_DECLARE_METATYPE(Core::Internal::ExternalTool *) +Q_DECLARE_METATYPE(Core::ExternalTool *) diff --git a/src/plugins/coreplugin/externaltoolmanager.cpp b/src/plugins/coreplugin/externaltoolmanager.cpp index 94bd49495a4..5753273e05a 100644 --- a/src/plugins/coreplugin/externaltoolmanager.cpp +++ b/src/plugins/coreplugin/externaltoolmanager.cpp @@ -61,13 +61,6 @@ static ExternalToolManager *m_instance = nullptr; static ExternalToolManagerPrivate *d = nullptr; static void writeSettings(); -static void readSettings(const QMap &tools, - QMap > *categoryPriorityMap); - -static void parseDirectory(const QString &directory, - QMap > *categoryMenus, - QMap *tools, - bool isPreset = false); ExternalToolManager::ExternalToolManager() : QObject(ICore::instance()) @@ -120,7 +113,7 @@ ExternalToolManager *ExternalToolManager::instance() return m_instance; } -static void parseDirectory(const QString &directory, +void ExternalToolManager::parseDirectory(const QString &directory, QMap > *categoryMenus, QMap *tools, bool isPreset) @@ -254,7 +247,7 @@ void ExternalToolManager::setToolsByCategory(const QMapmenu()->addAction(d->m_configureAction); } -static void readSettings(const QMap &tools, +void ExternalToolManager::readSettings(const QMap &tools, QMap > *categoryMap) { QSettings *settings = ICore::settings(); diff --git a/src/plugins/coreplugin/externaltoolmanager.h b/src/plugins/coreplugin/externaltoolmanager.h index 23ec6adc8af..67a932fee81 100644 --- a/src/plugins/coreplugin/externaltoolmanager.h +++ b/src/plugins/coreplugin/externaltoolmanager.h @@ -34,7 +34,7 @@ namespace Core { -namespace Internal { class ExternalTool; } +class ExternalTool; class CORE_EXPORT ExternalToolManager : public QObject { @@ -45,10 +45,17 @@ public: ~ExternalToolManager() override; static ExternalToolManager *instance(); - static QMap > toolsByCategory(); - static QMap toolsById(); - static void setToolsByCategory(const QMap > &tools); + static QMap > toolsByCategory(); + static QMap toolsById(); + static void setToolsByCategory(const QMap > &tools); static void emitReplaceSelectionRequested(const QString &output); + static void readSettings(const QMap &tools, + QMap > *categoryPriorityMap); + + static void parseDirectory(const QString &directory, + QMap > *categoryMenus, + QMap *tools, + bool isPreset = false); signals: void replaceSelectionRequested(const QString &text); diff --git a/tests/auto/externaltool/CMakeLists.txt b/tests/auto/externaltool/CMakeLists.txt index 944c3dc671c..c897bd6e8ac 100644 --- a/tests/auto/externaltool/CMakeLists.txt +++ b/tests/auto/externaltool/CMakeLists.txt @@ -2,6 +2,4 @@ add_qtc_test(tst_externaltooltest DEPENDS Core app_version SOURCES tst_externaltooltest.cpp - "${PROJECT_SOURCE_DIR}/src/plugins/coreplugin/externaltool.cpp" - "${PROJECT_SOURCE_DIR}/src/plugins/coreplugin/externaltool.h" ) diff --git a/tests/auto/externaltool/externaltool.qbs b/tests/auto/externaltool/externaltool.qbs index 932ad725fb7..74dcdfefa7d 100644 --- a/tests/auto/externaltool/externaltool.qbs +++ b/tests/auto/externaltool/externaltool.qbs @@ -5,15 +5,6 @@ QtcAutotest { Depends { name: "Core" } Depends { name: "app_version_header" } - Group { - name: "Duplicated sources from Core plugin" // Ewww. But the .pro file does the same. - prefix: project.ide_source_tree + "/src/plugins/coreplugin/" - files: [ - "externaltool.cpp", - "externaltool.h" - ] - } - Group { name: "Test sources" files: "tst_externaltooltest.cpp" diff --git a/tests/auto/externaltool/tst_externaltooltest.cpp b/tests/auto/externaltool/tst_externaltooltest.cpp index e7addf7a10c..dbd60bc8e34 100644 --- a/tests/auto/externaltool/tst_externaltooltest.cpp +++ b/tests/auto/externaltool/tst_externaltooltest.cpp @@ -28,7 +28,7 @@ #include -using namespace Core::Internal; +using namespace Core; using namespace Utils; static const char TEST_XML1[] =