From e47141753995f91565f8e3781315b40fe620d16c Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Fri, 18 Nov 2022 09:19:12 +0100 Subject: [PATCH] FilePath: optimize comparison * The QTC_ASSERT in pathView() is quite expensive * Constructing the scheme using scheme() is not required Change-Id: Ibea33dd6abf67c8bd184d118f23e2598075c362c Reviewed-by: hjk --- src/libs/utils/filepath.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/utils/filepath.cpp b/src/libs/utils/filepath.cpp index 11a2225c457..8e47d2ab3fc 100644 --- a/src/libs/utils/filepath.cpp +++ b/src/libs/utils/filepath.cpp @@ -342,7 +342,6 @@ QStringView FilePath::host() const QStringView FilePath::pathView() const { - QTC_ASSERT(!m_data.startsWith(u"/./"), return m_data.mid(3, m_pathLen - 3)); return m_data.left(m_pathLen); } @@ -1342,7 +1341,7 @@ bool FilePath::isNewerThan(const QDateTime &timeStamp) const */ Qt::CaseSensitivity FilePath::caseSensitivity() const { - if (scheme().isEmpty()) + if (m_schemeLen == 0) return HostOsInfo::fileNameCaseSensitivity(); // FIXME: This could or possibly should the target device's file name case sensitivity