From e4866a1667f845e9b65108fe36f3ccb443a4dc9a Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 11 Jan 2024 00:32:16 +0100 Subject: [PATCH] NavigationWidget: Avoid using keys() Instead, iterate directly over the container. Change-Id: I393ac1d42b08b7fcf2052ba601a550f28ad84c69 Reviewed-by: Reviewed-by: Eike Ziller --- src/plugins/coreplugin/navigationwidget.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/plugins/coreplugin/navigationwidget.cpp b/src/plugins/coreplugin/navigationwidget.cpp index d703624a5d2..0c744d723df 100644 --- a/src/plugins/coreplugin/navigationwidget.cpp +++ b/src/plugins/coreplugin/navigationwidget.cpp @@ -451,10 +451,9 @@ void NavigationWidget::saveSettings(QtcSettings *settings) settings->setValue(settingsKey("Width"), d->m_width); const Key activationKey = "ActivationPosition."; - const auto keys = s_activationsMap.keys(); - for (const auto &factoryId : keys) { - const auto &info = s_activationsMap[factoryId]; - const Utils::Key key = settingsKey(activationKey + factoryId.name()); + for (auto it = s_activationsMap.cbegin(); it != s_activationsMap.cend(); ++it) { + const auto &info = *it; + const Utils::Key key = settingsKey(activationKey + it.key().name()); if (info.side == d->m_side) settings->setValue(key, info.position); else