feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Use qAsConst with non-const Qt containers in range-loops

Browse Source 
Change-Id: Id9df0a27c4bcba57ee76574e32ca53cb6c28a43d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-16 20:44:17 +01:00
parent d6574a6e5f
commit e4f260d544
8 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/clangtools/clangtool.cpp
View File

@@ -270,7 +270,7 @@ public:
QVector<DiagnosticItem *> itemsSchedulable;
// Construct refactoring operations
for (DiagnosticItem *diagnosticItem : fileInfo.diagnosticItems) {
for (DiagnosticItem *diagnosticItem : qAsConst(fileInfo.diagnosticItems)) {
const FixitStatus fixItStatus = diagnosticItem->fixItStatus();
const bool isScheduled = fixItStatus == FixitStatus::Scheduled;
@@ -289,7 +289,7 @@ public:
// Collect replacements
ReplacementOperations ops;
for (DiagnosticItem *item : itemsScheduledOrSchedulable)
for (DiagnosticItem *item : qAsConst(itemsScheduledOrSchedulable))
ops += item->fixitOperations();
if (ops.empty())
@@ -311,11 +311,11 @@ public:
model->addWatchedPath(ops.first()->fileName);
// Update DiagnosticItem state
for (DiagnosticItem *diagnosticItem : itemsScheduled)
for (DiagnosticItem *diagnosticItem : qAsConst(itemsScheduled))
diagnosticItem->setFixItStatus(FixitStatus::Applied);
for (DiagnosticItem *diagnosticItem : itemsFailedToApply)
for (DiagnosticItem *diagnosticItem : qAsConst(itemsFailedToApply))
diagnosticItem->setFixItStatus(FixitStatus::FailedToApply);
for (DiagnosticItem *diagnosticItem : itemsInvalidated)
for (DiagnosticItem *diagnosticItem : qAsConst(itemsInvalidated))
diagnosticItem->setFixItStatus(FixitStatus::Invalidated);
}
}
@@ -333,7 +333,7 @@ static FileInfos sortedFileInfos(const QVector<CppTools::ProjectPart::Ptr> &proj
if (!projectPart->selectedForBuilding)
continue;
for (const CppTools::ProjectFile &file : projectPart->files) {
for (const CppTools::ProjectFile &file : qAsConst(projectPart->files)) {
QTC_ASSERT(file.kind != CppTools::ProjectFile::Unclassified, continue);
QTC_ASSERT(file.kind != CppTools::ProjectFile::Unsupported, continue);
if (file.path == CppTools::CppModelManager::configurationFileName())