From e50704d9610aa2a78b7b52707323dc27f3dbeb1f Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Mon, 17 Jun 2024 15:12:55 +0300 Subject: [PATCH] QmlDesigner: Use unique image key for each import 3D preview icon The shared memory is allocated based on the key, so if every icon is sent with same key, they will use the same shared memory. If QDS side doesn't read the image before the next image is written into the shared memory, QDS side will get wrong image if all images use same key. Fixes: QDS-13013 Change-Id: Ie8188520a76ca057a5b0f0927a7726652609fa35 Reviewed-by: Mahmoud Badri --- .../qml2puppet/instances/qt5import3dnodeinstanceserver.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tools/qml2puppet/qml2puppet/instances/qt5import3dnodeinstanceserver.cpp b/src/tools/qml2puppet/qml2puppet/instances/qt5import3dnodeinstanceserver.cpp index a3010819248..cfd8df339d3 100644 --- a/src/tools/qml2puppet/qml2puppet/instances/qt5import3dnodeinstanceserver.cpp +++ b/src/tools/qml2puppet/qml2puppet/instances/qt5import3dnodeinstanceserver.cpp @@ -345,7 +345,8 @@ void Qt5Import3dNodeInstanceServer::render() if (!data.name.isEmpty()) { QSizeF iconSize = m_iconView3D->size(); QImage iconImage = renderImage.copy(0, 0, iconSize.width(), iconSize.height()); - ImageContainer imgContainer(0, iconImage, 1000001); + static qint32 renderId = 1000001; + ImageContainer imgContainer(0, iconImage, ++renderId); QVariantList cmdData; cmdData.append(data.name); cmdData.append(QVariant::fromValue(imgContainer));