feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Rename isReference to isReadOnlyReference

Browse Source 
There is implicit knowledge that the reference is read only in the code
so we should honor that and make is explicit.

Change-Id: I0d6eab6595ae1414ad2607760a2e02fd49bafd72
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Marco Bubke
2016-02-22 11:58:34 +01:00
parent d1b3259246
commit e562af2c29
4 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/utils/smallstringlayout.h
View File

@@ -62,7 +62,7 @@ struct AllocatedLayout {
} data;
char dummy[maximumShortStringDataAreaSize - sizeof(Data)];
std::uint8_t shortStringSize: 6;
std::uint8_t isReference : 1;
std::uint8_t isReadOnlyReference : 1;
std::uint8_t hasAllocated : 1;
};
@@ -74,14 +74,14 @@ struct ReferenceLayout {
} data;
char dummy[maximumShortStringDataAreaSize - sizeof(Data)];
std::uint8_t shortStringSize: 6;
std::uint8_t isReference : 1;
std::uint8_t isReadOnlyReference : 1;
std::uint8_t hasAllocated : 1;
};
struct ShortStringLayout {
char string[maximumShortStringDataAreaSize];
std::uint8_t shortStringSize: 6;
std::uint8_t isReference : 1;
std::uint8_t isReadOnlyReference : 1;
std::uint8_t hasAllocated : 1;
};
@@ -112,14 +112,14 @@ struct ALIGNAS_16 StringDataLayout {
#pragma GCC diagnostic pop
#endif
shortString.hasAllocated = false;
shortString.isReference = false;
shortString.isReadOnlyReference = false;
} else {
reference.data.pointer = string;
reference.data.size = Size - 1;
reference.data.capacity = 0;
reference.shortStringSize = 0;
reference.hasAllocated = true;
reference.isReference = true;
reference.isReadOnlyReference = true;
}
#endif
}