From e58020c346d02b0c352c8d44f1a6ada1041468ec Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Mon, 5 Dec 2016 15:31:40 +0100 Subject: [PATCH] Utils: Do not dereference nullptr via errorMessage The errorMessage passed into this function apparently can be a nullptr, at least everywhere else it is checked whether or not errorMessage is nullptr before accessing it. Change-Id: If0920275ebce394a1b7085b815eaa6994b76ee3b Reviewed-by: Eike Ziller --- src/libs/utils/mimetypes/mimetypeparser.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libs/utils/mimetypes/mimetypeparser.cpp b/src/libs/utils/mimetypes/mimetypeparser.cpp index 643b9b192d1..ab43ffd3556 100644 --- a/src/libs/utils/mimetypes/mimetypeparser.cpp +++ b/src/libs/utils/mimetypes/mimetypeparser.cpp @@ -162,7 +162,8 @@ static bool parseNumber(const QString &n, int *target, QString *errorMessage) bool ok; *target = n.toInt(&ok); if (!ok) { - *errorMessage = QString::fromLatin1("Not a number '%1'.").arg(n); + if (errorMessage) + *errorMessage = QString::fromLatin1("Not a number '%1'.").arg(n); return false; } return true;