feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplore: Inline KitAspectWidget::{is,set}Mutable

Browse Source 
... into its only user. Less indirection, less code.

Change-Id: I8aa750c5850dff92c847eda8c2d6403cc3063f2d
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-02-12 10:18:26 +01:00
parent dde7857543
commit e59da46773
3 changed files with 4 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -496,16 +496,6 @@ Core::Id KitAspectWidget::kitInformationId() const
return m_kitInformation->id(); return m_kitInformation->id();
} }
bool KitAspectWidget::isMutable() const
{
return m_kit->isMutable(m_kitInformation->id());
}
void KitAspectWidget::setMutable(bool b)
{
m_kit->setMutable(m_kitInformation->id(), b);
}
QString KitAspectWidget::msgManage() QString KitAspectWidget::msgManage()
{ {
return tr("Manage..."); return tr("Manage...");

2
src/plugins/projectexplorer/kitmanager.h
View File

@@ -135,8 +135,6 @@ public:
virtual QWidget *buttonWidget() const { return nullptr; } virtual QWidget *buttonWidget() const { return nullptr; }
bool isSticky() const { return m_isSticky; } bool isSticky() const { return m_isSticky; }
bool isMutable() const;
void setMutable(bool b);
static QString msgManage(); static QString msgManage();

7
src/plugins/projectexplorer/kitmanagerconfigwidget.cpp
View File

@@ -232,12 +232,13 @@ void KitManagerConfigWidget::addAspectToWorkingCopy(KitAspect *aspect)
auto action = new QAction(tr("Mark as Mutable"), nullptr); auto action = new QAction(tr("Mark as Mutable"), nullptr);
action->setCheckable(true); action->setCheckable(true);
action->setChecked(widget->isMutable()); action->setChecked(workingCopy()->isMutable(aspect->id()));
action->setEnabled(!widget->isSticky()); action->setEnabled(!widget->isSticky());
widget->mainWidget()->addAction(action); widget->mainWidget()->addAction(action);
widget->mainWidget()->setContextMenuPolicy(Qt::ActionsContextMenu); widget->mainWidget()->setContextMenuPolicy(Qt::ActionsContextMenu);
connect(action, &QAction::toggled, this, [this, widget, action] { connect(action, &QAction::toggled, this, [this, aspect, action] {
widget->setMutable(action->isChecked()); workingCopy()->setMutable(aspect->id(), action->isChecked());
emit dirty(); emit dirty();
}); });