feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove unnecessary removeContextObject calls

Browse Source 
They are removed on deletion now.

Change-Id: I08461ea4938e24ab450df013a0f8f820032381da
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2020-05-26 14:48:38 +02:00
parent 7b5481f75c
commit e5bb7d1ffe
24 changed files with 46 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/projectexplorer/projecttreewidget.cpp
View File

@@ -152,11 +152,11 @@ public:
setDragDropMode(QAbstractItemView::DragDrop);
viewport()->setAcceptDrops(true);
setDropIndicatorShown(true);
m_context = new IContext(this);
m_context->setContext(Context(ProjectExplorer::Constants::C_PROJECT_TREE));
m_context->setWidget(this);
auto context = new IContext(this);
context->setContext(Context(ProjectExplorer::Constants::C_PROJECT_TREE));
context->setWidget(this);
ICore::addContextObject(m_context);
ICore::addContextObject(context);
connect(this, &ProjectTreeView::expanded,
this, &ProjectTreeView::invalidateSize);
@@ -204,12 +204,6 @@ public:
NavigationTreeView::setModel(newModel);
}
~ProjectTreeView() override
{
ICore::removeContextObject(m_context);
delete m_context;
}
int sizeHintForColumn(int column) const override
{
if (m_cachedSize < 0)
@@ -220,7 +214,6 @@ public:
private:
mutable int m_cachedSize = -1;
IContext *m_context;
};
/*!