feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtOptionsPageWidget::validInformation(): Use ToolChainManager::toolChain()

Browse Source 
Use a predicate to check whether any toolchain can be found instead
of searching through all of them.

Change-Id: I6d4417c548b37629dc43c11e313250c24777a5ca
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Friedemann Kleint
2017-01-19 12:54:16 +01:00
parent 99dff90bfa
commit e6017c40fc
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/qtsupport/qtoptionspage.cpp
View File

@@ -389,8 +389,15 @@ QtOptionsPageWidget::ValidityInfo QtOptionsPageWidget::validInformation(const Ba
// Do we have tool chain issues? // Do we have tool chain issues?
QList<Abi> missingToolChains; QList<Abi> missingToolChains;
const QList<Abi> qtAbis = version->qtAbis(); const QList<Abi> qtAbis = version->qtAbis();
for (const Abi &abi : qtAbis) { for (const Abi &abi : qtAbis) {
if (ToolChainManager::findToolChains(abi).isEmpty()) const auto abiCompatePred = [&abi] (const ToolChain *tc)
{
return Utils::contains(tc->supportedAbis(),
[&abi](const Abi &sabi) { return sabi.isCompatibleWith(abi); });
};
if (!ToolChainManager::toolChain(abiCompatePred))
missingToolChains.append(abi); missingToolChains.append(abi);
} }