From e66ae4ac76c6caf995a29d9b98fe7323dec648a4 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Mon, 18 Nov 2024 19:31:13 +0100 Subject: [PATCH] RunWorker: Remove recordData() / recordedData() methods Since there is no more usages of recordedData() - get rid of it. Thus storing any data without using them doesn't make sense. Change-Id: I1b527d22cc8a53b4f8df960ba9fd3d3436d7b822 Reviewed-by: hjk Reviewed-by: Ulf Hermann --- src/plugins/android/androidqmltoolingsupport.cpp | 5 +---- src/plugins/ios/iosrunner.cpp | 1 - src/plugins/projectexplorer/runcontrol.cpp | 11 ----------- src/plugins/projectexplorer/runcontrol.h | 3 --- .../qtapplicationmanager/appmanagerruncontrol.cpp | 1 - 5 files changed, 1 insertion(+), 20 deletions(-) diff --git a/src/plugins/android/androidqmltoolingsupport.cpp b/src/plugins/android/androidqmltoolingsupport.cpp index e7e6837754a..6c14f30c3fc 100644 --- a/src/plugins/android/androidqmltoolingsupport.cpp +++ b/src/plugins/android/androidqmltoolingsupport.cpp @@ -26,10 +26,7 @@ public: auto worker = runControl->createWorker(runnerIdForRunMode(runControl->runMode())); worker->addStartDependency(this); - connect(runner, &AndroidRunner::qmlServerReady, this, [this, worker](const QUrl &server) { - worker->recordData("QmlServerUrl", server); - reportStarted(); - }); + connect(runner, &AndroidRunner::qmlServerReady, this, &RunWorker::reportStarted); } private: diff --git a/src/plugins/ios/iosrunner.cpp b/src/plugins/ios/iosrunner.cpp index c33959e1b5d..9172fcc07c9 100644 --- a/src/plugins/ios/iosrunner.cpp +++ b/src/plugins/ios/iosrunner.cpp @@ -735,7 +735,6 @@ void IosQmlProfilerSupport::start() Port qmlPort = m_runner->qmlServerPort(); serverUrl.setPort(qmlPort.number()); - m_profiler->recordData("QmlServerUrl", serverUrl); if (qmlPort.isValid()) reportStarted(); else diff --git a/src/plugins/projectexplorer/runcontrol.cpp b/src/plugins/projectexplorer/runcontrol.cpp index fb0609af6ec..9dd64d03112 100644 --- a/src/plugins/projectexplorer/runcontrol.cpp +++ b/src/plugins/projectexplorer/runcontrol.cpp @@ -235,7 +235,6 @@ public: QList stopDependencies; QString id; - Store data; bool supportsReRunning = true; bool essential = false; }; @@ -1951,16 +1950,6 @@ void RunWorker::setId(const QString &id) d->id = id; } -void RunWorker::recordData(const Key &channel, const QVariant &data) -{ - d->data[channel] = data; -} - -QVariant RunWorker::recordedData(const Key &channel) const -{ - return d->data[channel]; -} - void RunWorker::setSupportsReRunning(bool reRunningSupported) { d->supportsReRunning = reRunningSupported; diff --git a/src/plugins/projectexplorer/runcontrol.h b/src/plugins/projectexplorer/runcontrol.h index 311a39f3440..4c37b1c9e78 100644 --- a/src/plugins/projectexplorer/runcontrol.h +++ b/src/plugins/projectexplorer/runcontrol.h @@ -56,9 +56,6 @@ public: void setId(const QString &id); - void recordData(const Utils::Key &channel, const QVariant &data); - QVariant recordedData(const Utils::Key &channel) const; - // Part of read-only interface of RunControl for convenience. void appendMessage(const QString &msg, Utils::OutputFormat format, bool appendNewLine = true); IDeviceConstPtr device() const; diff --git a/src/plugins/qtapplicationmanager/appmanagerruncontrol.cpp b/src/plugins/qtapplicationmanager/appmanagerruncontrol.cpp index 4f694bbbc6f..978e2158b51 100644 --- a/src/plugins/qtapplicationmanager/appmanagerruncontrol.cpp +++ b/src/plugins/qtapplicationmanager/appmanagerruncontrol.cpp @@ -277,7 +277,6 @@ public: private: void start() final { - m_worker->recordData("QmlServerUrl", qmlChannel()); reportStarted(); }