feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Quote path in msvc_make.bat

Browse Source 
Make the wrapper script more robust against spaces in the path of the
build tool.

The Qt Sdk installer installs Qt Creator Preview into paths with spaces,
together with a copy of jom.exe. The call of that jom.exe needs to be in
quotes.

Task-number: QTCREATORBUG-23174
Change-Id: Iffd958362cbce222f05a8505d9f8417d549afa11
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Alessandro Portale
2019-11-29 22:16:35 +01:00
parent 0afc338f3c
commit e69f8f2048
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/msvctoolchain.cpp
View File

@@ -1178,7 +1178,7 @@ static QString wrappedMakeCommand(const QString &command)
return command; return command;
QTextStream stream(&wrapper); QTextStream stream(&wrapper);
stream << "chcp 65001\n"; stream << "chcp 65001\n";
stream << command << " %*"; stream << "\"" << QDir::toNativeSeparators(command) << "\" %*";
return wrapperPath; return wrapperPath;
} }