feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Avoid returning value by reference

Browse Source 
Change-Id: Id094d6f70a0e3eb8ef9cb6336880f6ff9187d7df
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-10-06 20:04:04 +02:00
parent 70466ed811
commit e6bfa33be0
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/fossil/fossilplugin.cpp
View File

@@ -1004,8 +1004,7 @@ VcsCommand *FossilPluginPrivate::createInitialCheckoutCommand(const QString &sou
const QString &localName, const QString &localName,
const QStringList &extraArgs) const QStringList &extraArgs)
{ {
QMap<QString, QString> options; const QMap<QString, QString> options = FossilJsExtension::parseArgOptions(extraArgs);
FossilJsExtension::parseArgOptions(extraArgs, options);
// Two operating modes: // Two operating modes:
// 1) CloneCheckout: // 1) CloneCheckout:

6
plugins/fossil/wizard/fossiljsextension.cpp
View File

@@ -52,16 +52,16 @@ public:
}; };
void FossilJsExtension::parseArgOptions(const QStringList &args, QMap<QString, QString> &options) QMap<QString, QString> FossilJsExtension::parseArgOptions(const QStringList &args)
{ {
options.clear(); QMap<QString, QString> options;
for (const QString &arg : args) { for (const QString &arg : args) {
if (arg.isEmpty()) if (arg.isEmpty())
continue; continue;
const QStringList opt = arg.split('|', Qt::KeepEmptyParts); const QStringList opt = arg.split('|', Qt::KeepEmptyParts);
options.insert(opt[0], opt.size() > 1 ? opt[1] : QString()); options.insert(opt[0], opt.size() > 1 ? opt[1] : QString());
} }
return options;
} }
FossilJsExtension::FossilJsExtension(FossilSettings *settings) : FossilJsExtension::FossilJsExtension(FossilSettings *settings) :

2
plugins/fossil/wizard/fossiljsextension.h
View File

@@ -42,7 +42,7 @@ class FossilJsExtension : public QObject
Q_OBJECT Q_OBJECT
public: public:
static void parseArgOptions(const QStringList &args, QMap<QString, QString> &options); static QMap<QString, QString> parseArgOptions(const QStringList &args);
FossilJsExtension(FossilSettings *settings); FossilJsExtension(FossilSettings *settings);
~FossilJsExtension(); ~FossilJsExtension();