feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ShellCommand: Remove success() signal

Browse Source 
Use finished() signal instead.

Change-Id: I4e28a2c6d90f40790cb9d19411186bd98402f4bb
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-29 12:48:29 +02:00
parent 79aaf155b7
commit e6e4bc8dad
5 changed files with 41 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/utils/shellcommand.cpp
View File

@@ -279,12 +279,10 @@ void ShellCommand::run(QFutureInterface<void> &future)
}
emit finished(lastExecSuccess, cookie());
if (lastExecSuccess) {
emit success(cookie());
if (lastExecSuccess)
future.setProgressValue(future.progressMaximum());
} else {
else
future.cancel(); // sets the progress indicator red
}
}
if (d->m_progressParser)