feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Copilot: correctly cleanup compression timer

Browse Source 
fixes a leak and a crash if the timer triggers after the widget was
deleted.

Change-Id: I57794009186d4c5e4dee0b0c0746ffc5468000b7
Reviewed-by: Artem Sokolovskii <artem.sokolovskii@qt.io>
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
David Schulz
2023-03-24 11:27:21 +01:00
parent 1be65dd1ee
commit e6e895d6be
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/copilot/copilotclient.cpp
View File

@@ -108,6 +108,11 @@ void CopilotClient::scheduleRequest(TextEditorWidget *editor)
m_scheduledRequests[editor].timer->start(500); m_scheduledRequests[editor].timer->start(500);
} }
CopilotClient::ScheduleData::~ScheduleData()
{
delete timer;
}
void CopilotClient::requestCompletions(TextEditorWidget *editor) void CopilotClient::requestCompletions(TextEditorWidget *editor)
{ {
Utils::MultiTextCursor cursor = editor->multiTextCursor(); Utils::MultiTextCursor cursor = editor->multiTextCursor();

1
src/plugins/copilot/copilotclient.h
View File

@@ -50,6 +50,7 @@ private:
QMap<TextEditor::TextEditorWidget *, GetCompletionRequest> m_runningRequests; QMap<TextEditor::TextEditorWidget *, GetCompletionRequest> m_runningRequests;
struct ScheduleData struct ScheduleData
{ {
~ScheduleData();
int cursorPosition = -1; int cursorPosition = -1;
QTimer *timer = nullptr; QTimer *timer = nullptr;
}; };