From e73f05253eb488a385d9346392b791b877f8da27 Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 5 May 2020 12:49:01 +0200 Subject: [PATCH] Debugger: Simplify LLDB bridge startup No need to start the debugger event loop if the engine setup fails Change-Id: I6bdeda0d2609c79aa5fafff7bc4b373a0bf14fbd Reviewed-by: David Schulz Reviewed-by: Christian Stenger --- share/qtcreator/debugger/lldbbridge.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/share/qtcreator/debugger/lldbbridge.py b/share/qtcreator/debugger/lldbbridge.py index 8ce954ce1ce..dde767aef6b 100644 --- a/share/qtcreator/debugger/lldbbridge.py +++ b/share/qtcreator/debugger/lldbbridge.py @@ -108,7 +108,6 @@ class Dumper(DumperBase): self.process = None self.target = None self.eventState = lldb.eStateInvalid - self.runEngineAttempted = False self.executable_ = None self.symbolFile_ = None @@ -923,14 +922,6 @@ class Dumper(DumperBase): % (state, error, self.executable_), args) def runEngine(self, args): - if self.runEngineAttempted: - return - self.runEngineAttempted = True - self.prepare(args) - s = threading.Thread(target=self.loop, args=[]) - s.start() - - def prepare(self, args): error = lldb.SBError() if self.attachPid_ > 0 and self.platform_ != "remote-linux": @@ -999,6 +990,9 @@ class Dumper(DumperBase): self.report('pid="%s"' % self.process.GetProcessID()) self.reportState('enginerunandinferiorrunok') + s = threading.Thread(target=self.loop, args=[]) + s.start() + def loop(self): event = lldb.SBEvent() #broadcaster = self.target.GetBroadcaster()