feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Filter out non-applicable toolchains

Browse Source 
... when filling the "parent toolchain" combo box for clang on Windows.
We should not offer the user a mingw C compiler as the parent of a clang
C++ compiler. Even though it will probably work (as it's mainly there
for the sysroot), it's conceptually weird and it blows up the number of
entries for no good reason.

Change-Id: Ic920993b4ff36f8d8d095392555dc9d27f376878
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Kandeler
2020-09-08 11:22:11 +02:00
parent 92f9502f56
commit e778283b08
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/projectexplorer/gcctoolchain.cpp
View File

@@ -1720,8 +1720,11 @@ void ClangToolChainConfigWidget::updateParentToolChainComboBox()
return; return;
for (const ToolChain *mingwTC : mingwToolChains()) { for (const ToolChain *mingwTC : mingwToolChains()) {
if (parentId != mingwTC->id()) if (mingwTC->id() == parentId)
m_parentToolchainCombo->addItem(mingwTC->displayName(), mingwTC->id()); continue;
if (mingwTC->language() != tc->language())
continue;
m_parentToolchainCombo->addItem(mingwTC->displayName(), mingwTC->id());
} }
} }