feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Make sure all changes to device settings are applied

Browse Source 
The old "editingFinished on macOS" problem hits again.
A cursory glance seems to suggest the required call to
updateDeviceFromUi() was missing already in the original patch
dff0761406.

Change-Id: Id286417962010bfffe98169b55fb42e3480b03f6
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Christian Kandeler
2023-03-21 13:25:46 +01:00
parent 20af0711d5
commit e788d0e8da
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/projectexplorer/devicesupport/devicesettingswidget.cpp
View File

@@ -251,6 +251,7 @@ void DeviceSettingsWidget::updateDeviceFromUi()
void DeviceSettingsWidget::saveSettings() void DeviceSettingsWidget::saveSettings()
{ {
updateDeviceFromUi();
ICore::settings()->setValueWithDefault(LastDeviceIndexKey, currentIndex(), 0); ICore::settings()->setValueWithDefault(LastDeviceIndexKey, currentIndex(), 0);
DeviceManager::replaceInstance(); DeviceManager::replaceInstance();
} }

1
src/plugins/remotelinux/genericlinuxdeviceconfigurationwidget.cpp
View File

@@ -223,6 +223,7 @@ void GenericLinuxDeviceConfigurationWidget::updateDeviceFromUi()
keyFileEditingFinished(); keyFileEditingFinished();
handleFreePortsChanged(); handleFreePortsChanged();
gdbServerEditingFinished(); gdbServerEditingFinished();
qmlRuntimeEditingFinished();
} }
void GenericLinuxDeviceConfigurationWidget::updatePortsWarningLabel() void GenericLinuxDeviceConfigurationWidget::updatePortsWarningLabel()