feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DiffEditor: Pass const lists and string by reference

Browse Source 
Change-Id: I6acdc4db61aeed1353bed2207736268dfabf3f17
Reviewed-by: Jarek Kobus <jaroslaw.kobus@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-19 18:33:04 +03:00
committed by Orgad Shaneh
parent fb82943e6f
commit e7a7c02b4d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/diffeditor/differ.cpp
View File

@@ -590,7 +590,7 @@ static QString encodeExpandedWhitespace(const QString &leftEquality,
* The input argument contains version encoded with codeMap,
* the returned value contains decoded diff list.
*/
static QList<Diff> decodeExpandedWhitespace(const QList<Diff> input,
static QList<Diff> decodeExpandedWhitespace(const QList<Diff> &input,
const QMap<int, QPair<int, QString> > &codeMap,
bool *ok)
{
@@ -1125,7 +1125,7 @@ QList<Diff> Differ::diffMyersSplit(
return diffList1 + diffList2;
}
QList<Diff> Differ::diffNonCharMode(const QString text1, const QString text2)
QList<Diff> Differ::diffNonCharMode(const QString &text1, const QString &text2)
{
QString encodedText1;
QString encodedText2;

2
src/plugins/diffeditor/differ.h
View File

@@ -99,7 +99,7 @@ private:
QList<Diff> diffMyers(const QString &text1, const QString &text2);
QList<Diff> diffMyersSplit(const QString &text1, int x,
const QString &text2, int y);
QList<Diff> diffNonCharMode(const QString text1, const QString text2);
QList<Diff> diffNonCharMode(const QString &text1, const QString &text2);
QStringList encode(const QString &text1,
const QString &text2,
QString *encodedText1,