feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ios: fix deploystep displayName updating

Browse Source 
still uses the default deploystepconfiguration, which gives some
artifacts (to be fixed later)

Change-Id: I3f4f8a71fbe4e18fc171aee571da72da1c9735db
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Fawzi Mohamed
2014-05-13 16:09:11 +02:00
parent f7a4e44764
commit e7ac3bf16e
3 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/plugins/ios/iosdeploystep.cpp
View File

@@ -40,6 +40,9 @@
#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectexplorerconstants.h>
#include <projectexplorer/target.h> #include <projectexplorer/target.h>
#include <projectexplorer/taskhub.h> #include <projectexplorer/taskhub.h>
#include <projectexplorer/kitmanager.h>
#include <projectexplorer/kitinformation.h>
#include <projectexplorer/devicesupport/devicemanager.h>
#include <qmakeprojectmanager/qmakebuildconfiguration.h> #include <qmakeprojectmanager/qmakebuildconfiguration.h>
#include <qmakeprojectmanager/qmakeproject.h> #include <qmakeprojectmanager/qmakeproject.h>
#include <qmakeprojectmanager/qmakenodes.h> #include <qmakeprojectmanager/qmakenodes.h>
@@ -82,14 +85,26 @@ void IosDeployStep::ctor()
{ {
m_toolHandler = 0; m_toolHandler = 0;
m_transferStatus = NoTransfer; m_transferStatus = NoTransfer;
m_device = ProjectExplorer::DeviceKitInformation::device(target()->kit()); cleanup();
const QString devName = m_device.isNull() ? IosDevice::name() : m_device->displayName(); updateDisplayNames();
connect(DeviceManager::instance(), SIGNAL(updated()),
SLOT(updateDisplayNames()));
connect(target(), SIGNAL(kitChanged()),
SLOT(updateDisplayNames()));
}
void IosDeployStep::updateDisplayNames()
{
ProjectExplorer::IDevice::ConstPtr dev =
ProjectExplorer::DeviceKitInformation::device(target()->kit());
const QString devName = dev.isNull() ? IosDevice::name() : dev->displayName();
setDefaultDisplayName(tr("Deploy to %1").arg(devName)); setDefaultDisplayName(tr("Deploy to %1").arg(devName));
setDisplayName(tr("Deploy to %1").arg(devName));
} }
bool IosDeployStep::init() bool IosDeployStep::init()
{ {
QTC_CHECK(m_transferStatus == NoTransfer); QTC_ASSERT(m_transferStatus == NoTransfer, return false);
m_device = ProjectExplorer::DeviceKitInformation::device(target()->kit()); m_device = ProjectExplorer::DeviceKitInformation::device(target()->kit());
IosRunConfiguration * runConfig = qobject_cast<IosRunConfiguration *>( IosRunConfiguration * runConfig = qobject_cast<IosRunConfiguration *>(
this->target()->activeRunConfiguration()); this->target()->activeRunConfiguration());

8
src/plugins/ios/iosdeploystep.h
View File

@@ -73,9 +73,6 @@ public:
void run(QFutureInterface<bool> &fi) QTC_OVERRIDE; void run(QFutureInterface<bool> &fi) QTC_OVERRIDE;
void cleanup(); void cleanup();
ProjectExplorer::IDevice::ConstPtr device() const;
IosDevice::ConstPtr iosdevice() const;
IosSimulator::ConstPtr iossimulator() const;
void cancel(); void cancel();
signals: signals:
//void done(); //void done();
@@ -89,7 +86,7 @@ private slots:
Ios::IosToolHandler::OpStatus status); Ios::IosToolHandler::OpStatus status);
void handleFinished(Ios::IosToolHandler *handler); void handleFinished(Ios::IosToolHandler *handler);
void handleErrorMsg(Ios::IosToolHandler *handler, const QString &msg); void handleErrorMsg(Ios::IosToolHandler *handler, const QString &msg);
void updateDisplayNames();
private: private:
IosDeployStep(ProjectExplorer::BuildStepList *bc, IosDeployStep(ProjectExplorer::BuildStepList *bc,
IosDeployStep *other); IosDeployStep *other);
@@ -97,6 +94,9 @@ private:
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() QTC_OVERRIDE; ProjectExplorer::BuildStepConfigWidget *createConfigWidget() QTC_OVERRIDE;
bool immutable() const QTC_OVERRIDE { return true; } bool immutable() const QTC_OVERRIDE { return true; }
bool runInGuiThread() const QTC_OVERRIDE { return true; } bool runInGuiThread() const QTC_OVERRIDE { return true; }
ProjectExplorer::IDevice::ConstPtr device() const;
IosDevice::ConstPtr iosdevice() const;
IosSimulator::ConstPtr iossimulator() const;
void ctor(); void ctor();
QString deviceId() const; QString deviceId() const;

4
src/plugins/ios/iosdeploystepwidget.cpp
View File

@@ -46,6 +46,7 @@ IosDeployStepWidget::IosDeployStepWidget(IosDeployStep *step) :
m_step(step) m_step(step)
{ {
ui->setupUi(this); ui->setupUi(this);
connect(m_step, SIGNAL(displayNameChanged()), SIGNAL(updateSummary()));
} }
IosDeployStepWidget::~IosDeployStepWidget() IosDeployStepWidget::~IosDeployStepWidget()
@@ -55,8 +56,7 @@ IosDeployStepWidget::~IosDeployStepWidget()
QString IosDeployStepWidget::displayName() const QString IosDeployStepWidget::displayName() const
{ {
const QString deviceName = m_step->device().isNull() ? IosDevice::name() : m_step->device()->displayName(); return QString::fromLatin1("<b>%1</b>").arg(m_step->displayName());
return tr("<b>Deploy to %1</b>").arg(deviceName);
} }
QString IosDeployStepWidget::summaryText() const QString IosDeployStepWidget::summaryText() const