feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CorePlugin: Don't leak actions for options

Browse Source 
Amends d86a67e0bc

Change-Id: I45703f4fbc018f1f30375e578aa6c55815db902b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2022-11-02 15:31:09 +01:00
parent 3bfebea981
commit e7b1561cc7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/coreplugin/coreplugin.cpp
View File

@@ -258,12 +258,12 @@ static void registerActionsForOptions()
categoryDisplay[page->category()] = page->displayCategory(); categoryDisplay[page->category()] = page->displayCategory();
} }
for (IOptionsPage *page : IOptionsPage::allOptionsPages()) { for (IOptionsPage *page : IOptionsPage::allOptionsPages()) {
Id commandId = generateOpenPageCommandId(page); const Id commandId = generateOpenPageCommandId(page);
if (!commandId.isValid()) if (!commandId.isValid())
continue; continue;
const QString actionTitle = Tr::tr("%1 > %2 Preferences...") const QString actionTitle = Tr::tr("%1 > %2 Preferences...")
.arg(categoryDisplay.value(page->category()), page->displayName()); .arg(categoryDisplay.value(page->category()), page->displayName());
auto action = new QAction(actionTitle); auto action = new QAction(actionTitle, m_instance);
QObject::connect(action, &QAction::triggered, m_instance, [id = page->id()]() { QObject::connect(action, &QAction::triggered, m_instance, [id = page->id()]() {
ICore::showOptionsDialog(id); ICore::showOptionsDialog(id);
}); });