feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SubmitEditorWidget: Avoid using sender()

Browse Source 
Change-Id: I748dbf6232e89ffe0e412894bf708434be247e31
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-19 18:29:04 +02:00
parent 7f4363e51a
commit e7b43b6b8b
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/vcsbase/submiteditorwidget.cpp
View File

@@ -81,9 +81,6 @@ class QActionPushButton : public QToolButton
Q_OBJECT Q_OBJECT
public: public:
explicit QActionPushButton(QAction *a); explicit QActionPushButton(QAction *a);
private slots:
void actionChanged();
}; };
QActionPushButton::QActionPushButton(QAction *a) : QActionPushButton::QActionPushButton(QAction *a) :
@@ -92,20 +89,14 @@ QActionPushButton::QActionPushButton(QAction *a) :
setIcon(a->icon()); setIcon(a->icon());
setText(a->text()); setText(a->text());
setToolButtonStyle(Qt::ToolButtonTextBesideIcon); setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
connect(a, &QAction::changed, this, &QActionPushButton::actionChanged); connect(a, &QAction::changed, this, [this, a] {
setEnabled(a->isEnabled());
setText(a->text());
});
connect(this, &QAbstractButton::clicked, a, &QAction::trigger); connect(this, &QAbstractButton::clicked, a, &QAction::trigger);
setEnabled(a->isEnabled()); setEnabled(a->isEnabled());
} }
void QActionPushButton::actionChanged()
{
if (const QAction *a = qobject_cast<QAction*>(sender())) {
setEnabled(a->isEnabled());
setText(a->text());
}
}
// Helpers to retrieve model data // Helpers to retrieve model data
// Convenience to extract a list of selected indexes // Convenience to extract a list of selected indexes
// ----------- SubmitEditorWidgetPrivate // ----------- SubmitEditorWidgetPrivate