feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Qt versions/qmake dialog: Join filter list correctly.

Browse Source 
Do not add a trailing blank.

Change-Id: I0b187345415d96508be495860c530bd2f0c292c6
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
Friedemann Kleint
2012-05-15 15:24:49 +02:00
parent e9b8d1f929
commit e7fe8de4dd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qtsupport/qtoptionspage.cpp
View File

@@ -642,12 +642,15 @@ QtOptionsPageWidget::~QtOptionsPageWidget()
static QString filterForQmakeFileDialog() static QString filterForQmakeFileDialog()
{ {
QString filter = QLatin1String("qmake ("); QString filter = QLatin1String("qmake (");
foreach (const QString &s, Utils::BuildableHelperLibrary::possibleQMakeCommands()) { const QStringList commands = Utils::BuildableHelperLibrary::possibleQMakeCommands();
for (int i = 0; i < commands.size(); ++i) {
if (i)
filter += QLatin1Char(' ');
#ifdef Q_OS_MAC #ifdef Q_OS_MAC
// work around QTBUG-7739 that prohibits filters that don't start with * // work around QTBUG-7739 that prohibits filters that don't start with *
filter += QLatin1Char('*'); filter += QLatin1Char('*');
#endif #endif
filter += s + QLatin1Char(' '); filter += commands.at(i);
} }
filter += QLatin1Char(')'); filter += QLatin1Char(')');
return filter; return filter;