diff --git a/src/tools/clangbackend/ipcsource/clangdocument.cpp b/src/tools/clangbackend/ipcsource/clangdocument.cpp index 344787bbac1..fcb4d4e4100 100644 --- a/src/tools/clangbackend/ipcsource/clangdocument.cpp +++ b/src/tools/clangbackend/ipcsource/clangdocument.cpp @@ -107,7 +107,7 @@ Document::Document(const Utf8String &filePath, fileArguments, documents)) { - if (fileExistsCheck == CheckIfFileExists) + if (fileExistsCheck == FileExistsCheck::Check) checkIfFileExists(); } diff --git a/src/tools/clangbackend/ipcsource/clangdocument.h b/src/tools/clangbackend/ipcsource/clangdocument.h index ab6322eff1c..596c0fd7ebf 100644 --- a/src/tools/clangbackend/ipcsource/clangdocument.h +++ b/src/tools/clangbackend/ipcsource/clangdocument.h @@ -54,9 +54,9 @@ class Documents; class Document { public: - enum FileExistsCheck { - CheckIfFileExists, - DoNotCheckIfFileExists + enum class FileExistsCheck { + Check, + DoNotCheck }; Document() = default; @@ -64,7 +64,7 @@ public: const ProjectPart &projectPart, const Utf8StringVector &fileArguments, Documents &documents, - FileExistsCheck fileExistsCheck = CheckIfFileExists); + FileExistsCheck fileExistsCheck = FileExistsCheck::Check); ~Document(); Document(const Document &cxTranslationUnit); diff --git a/src/tools/clangbackend/ipcsource/clangdocuments.cpp b/src/tools/clangbackend/ipcsource/clangdocuments.cpp index 6888597a826..d8c0a6a324c 100644 --- a/src/tools/clangbackend/ipcsource/clangdocuments.cpp +++ b/src/tools/clangbackend/ipcsource/clangdocuments.cpp @@ -218,7 +218,9 @@ const ClangFileSystemWatcher *Documents::clangFileSystemWatcher() const Document Documents::createDocument(const FileContainer &fileContainer) { - Document::FileExistsCheck checkIfFileExists = fileContainer.hasUnsavedFileContent() ? Document::DoNotCheckIfFileExists : Document::CheckIfFileExists; + const Document::FileExistsCheck checkIfFileExists = fileContainer.hasUnsavedFileContent() + ? Document::FileExistsCheck::DoNotCheck + : Document::FileExistsCheck::Check; documents_.emplace_back(fileContainer.filePath(), projectParts.project(fileContainer.projectPartId()), diff --git a/tests/unit/unittest/clangdocument-test.cpp b/tests/unit/unittest/clangdocument-test.cpp index 4dec96a86bd..1d7d810ea07 100644 --- a/tests/unit/unittest/clangdocument-test.cpp +++ b/tests/unit/unittest/clangdocument-test.cpp @@ -108,13 +108,15 @@ TEST_F(Document, DefaultDocumentIsNotIntact) TEST_F(Document, ThrowExceptionForNonExistingFilePath) { - ASSERT_THROW(::Document(Utf8StringLiteral("file.cpp"), projectPart, Utf8StringVector(), documents), + ASSERT_THROW(::Document(Utf8StringLiteral("file.cpp"), projectPart, Utf8StringVector(), + documents), ClangBackEnd::DocumentFileDoesNotExistException); } TEST_F(Document, ThrowNoExceptionForNonExistingFilePathIfDoNotCheckIfFileExistsIsSet) { - ASSERT_NO_THROW(::Document(Utf8StringLiteral("file.cpp"), projectPart, Utf8StringVector(), documents, ::Document::DoNotCheckIfFileExists)); + ASSERT_NO_THROW(::Document(Utf8StringLiteral("file.cpp"), projectPart, Utf8StringVector(), + documents, ::Document::FileExistsCheck::DoNotCheck)); } TEST_F(Document, DocumentIsValid)