From e8383bc3b2c2cff2caa2ef062cc8f3d54d620a8c Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Wed, 11 Dec 2024 08:25:34 +0100 Subject: [PATCH] PE: Fix possible crash In case of an invalid device we may crash when trying to generate a build directory path. Prevent this by leaving earlier. Change-Id: Ieb02abd98467693d38df6dde434e2a6962e4d137 Reviewed-by: Marcus Tillmanns --- src/plugins/projectexplorer/buildconfiguration.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index 1f076e0751b..c6fd9f43988 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -644,6 +644,8 @@ FilePath BuildConfiguration::buildDirectoryFromTemplate(const FilePath &projectD buildDir = buildDir.withNewPath(buildDir.path().replace(" ", "-")); auto buildDevice = BuildDeviceKitAspect::device(kit); + if (!buildDevice) + return buildDir; if (buildDir.isAbsolutePath()) return buildDevice->rootPath().withNewMappedPath(buildDir);