From e8669653f11f91923826af0edcbcde99d12dc904 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Thu, 20 Jul 2023 12:38:52 +0200
Subject: [PATCH] Icon: Pass const reference to QList in c'tor

Change-Id: I8e009cdd29d08fc0dbcac3c812885779c928337c
Reviewed-by: hjk <hjk@qt.io>
---
 src/libs/utils/icon.cpp | 6 +++---
 src/libs/utils/icon.h   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/libs/utils/icon.cpp b/src/libs/utils/icon.cpp
index d2e4737d479..9c7625e32b2 100644
--- a/src/libs/utils/icon.cpp
+++ b/src/libs/utils/icon.cpp
@@ -134,15 +134,15 @@ static QPixmap masksToIcon(const MasksAndColors &masks, const QPixmap &combinedM
 
 Icon::Icon() = default;
 
-Icon::Icon(QList<IconMaskAndColor> args, Icon::IconStyleOptions style)
-    : m_iconSourceList(std::move(args))
+Icon::Icon(const QList<IconMaskAndColor> &args, Icon::IconStyleOptions style)
+    : m_iconSourceList(args)
     , m_style(style)
 {
 }
 
 Icon::Icon(const FilePath &imageFileName)
+    : m_iconSourceList({{imageFileName, Theme::Color(-1)}})
 {
-    m_iconSourceList.append({imageFileName, Theme::Color(-1)});
 }
 
 QIcon Icon::icon() const
diff --git a/src/libs/utils/icon.h b/src/libs/utils/icon.h
index ea1384ffd3c..b1482410a3d 100644
--- a/src/libs/utils/icon.h
+++ b/src/libs/utils/icon.h
@@ -40,7 +40,7 @@ public:
     Q_DECLARE_FLAGS(IconStyleOptions, IconStyleOption)
 
     Icon();
-    Icon(QList<IconMaskAndColor> args, IconStyleOptions style = ToolBarStyle);
+    Icon(const QList<IconMaskAndColor> &args, IconStyleOptions style = ToolBarStyle);
     Icon(const FilePath &imageFileName);
 
     QIcon icon() const;