feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Use likely attribute

Browse Source 
Change-Id: Iace372facd11c101a0f0a1b11ca585b374f42f1e
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Marco Bubke
2025-04-12 11:40:43 +02:00
parent a8541126c4
commit e871146b29
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/libs/utils/smallstringlayout.h
View File

@@ -119,7 +119,7 @@ struct alignas(16) StringDataLayout
StringDataLayout(const char *string, size_type size, size_type capacity) noexcept StringDataLayout(const char *string, size_type size, size_type capacity) noexcept
{ {
if (Q_LIKELY(capacity <= shortStringCapacity())) { if (capacity <= shortStringCapacity()) [[likely]] {
control = Internal::ControlBlock<MaximumShortStringDataAreaSize>(size, false, false); control = Internal::ControlBlock<MaximumShortStringDataAreaSize>(size, false, false);
std::char_traits<char>::copy(shortString, string, size); std::char_traits<char>::copy(shortString, string, size);
} else { } else {
@@ -181,11 +181,20 @@ struct alignas(16) StringDataLayout
constexpr bool isReadOnlyReference() const noexcept { return control.isReadOnlyReference(); } constexpr bool isReadOnlyReference() const noexcept { return control.isReadOnlyReference(); }
char *data() noexcept { return Q_LIKELY(isShortString()) ? shortString : reference.pointer; } char *data() noexcept
{
if (isShortString()) [[likely]]
return shortString;
else
return reference.pointer;
}
const char *data() const noexcept const char *data() const noexcept
{ {
return Q_LIKELY(isShortString()) ? shortString : reference.pointer; if (isShortString()) [[likely]]
return shortString;
else
return reference.pointer;
} }
void setPointer(char *p) noexcept { reference.pointer = p; } void setPointer(char *p) noexcept { reference.pointer = p; }
@@ -266,7 +275,7 @@ struct alignas(16) StringDataLayout<MaximumShortStringDataAreaSize,
: size_{static_cast<int>(size)} : size_{static_cast<int>(size)}
, capacity_{static_cast<int>(std::max<size_type>(capacity, MaximumShortStringDataAreaSize))} , capacity_{static_cast<int>(std::max<size_type>(capacity, MaximumShortStringDataAreaSize))}
{ {
if (Q_LIKELY(capacity <= shortStringCapacity())) { if (capacity <= shortStringCapacity()) [[likely]] {
std::char_traits<char>::copy(buffer, string, size); std::char_traits<char>::copy(buffer, string, size);
pointer = buffer; pointer = buffer;
} else { } else {