feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: 'replace' the adapter memory cache with gdb's own.

Browse Source 
This works better with larger gdb cache lines.
See #define LINE_SIZE_POWER 8 in gdb/dcache.c:105.
This commit is contained in:
hjk
2010-01-18 16:43:20 +01:00
parent 4030706c04
commit e8c15eab33
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/debugger/gdb/trkgdbadapter.cpp
View File

@@ -211,8 +211,9 @@ TrkGdbAdapter::TrkGdbAdapter(GdbEngine *engine, const TrkOptionsPtr &options) :
m_gdbAckMode(true), m_gdbAckMode(true),
m_verbose(0) m_verbose(0)
{ {
m_bufferedMemoryRead = false;
m_bufferedMemoryRead = true; m_bufferedMemoryRead = true;
// Disable buffering if gdb's dcache is used.
m_bufferedMemoryRead = false;
m_gdbServer = 0; m_gdbServer = 0;
m_gdbConnection = 0; m_gdbConnection = 0;
@@ -1498,8 +1499,6 @@ void TrkGdbAdapter::reportReadMemoryBuffered(const TrkResult &result)
void TrkGdbAdapter::handleStepInto(const TrkResult &result) void TrkGdbAdapter::handleStepInto(const TrkResult &result)
{ {
debugMessage(_("RESET SNAPSHOT"));
m_snapshot.reset();
if (result.errorCode()) { if (result.errorCode()) {
logMessage("ERROR: " + result.errorString() + " in handleStepInto"); logMessage("ERROR: " + result.errorString() + " in handleStepInto");
@@ -1541,8 +1540,6 @@ void TrkGdbAdapter::handleStepInto2(const TrkResult &result)
void TrkGdbAdapter::handleStepOver(const TrkResult &result) void TrkGdbAdapter::handleStepOver(const TrkResult &result)
{ {
debugMessage(_("RESET SNAPSHOT"));
m_snapshot.reset();
if (result.errorCode()) { if (result.errorCode()) {
logMessage("ERROR: " + result.errorString() + "in handleStepOver"); logMessage("ERROR: " + result.errorString() + "in handleStepOver");
// Try fallback with Step Into // Try fallback with Step Into
@@ -1775,6 +1772,12 @@ void TrkGdbAdapter::handleCreateProcess(const TrkResult &result)
// + QByteArray::number(m_session.codeseg)); // + QByteArray::number(m_session.codeseg));
m_engine->postCommand("symbol-file \"" + symbolFile + "\""); m_engine->postCommand("symbol-file \"" + symbolFile + "\"");
} }
m_engine->postCommand("set trust-readonly-sections"); // No difference?
m_engine->postCommand("set displaced-stepping on"); // No difference?
m_engine->postCommand("mem 0x00400000 0x00800000 cache");
m_engine->postCommand("mem 0x78000000 0x88000000 cache ro");
// FIXME: replace with stack-cache for newer gdb?
m_engine->postCommand("set remotecache on"); // "info dcache" to check
m_engine->postCommand("target remote " + gdbServerName().toLatin1(), m_engine->postCommand("target remote " + gdbServerName().toLatin1(),
CB(handleTargetRemote)); CB(handleTargetRemote));
} }