feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Guard against nullptr access

Browse Source 
Change-Id: I0378b043ed240533ce6f4b341705dc84d6ede7eb
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2020-10-14 11:11:57 +02:00
parent 239a59c596
commit e95041c054
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/autotest/testrunner.cpp
View File

@@ -307,13 +307,14 @@ void TestRunner::onProcessFinished()
QTC_CHECK(m_fakeFutureInterface); QTC_CHECK(m_fakeFutureInterface);
m_fakeFutureInterface->setProgressValue(m_fakeFutureInterface->progressValue() m_fakeFutureInterface->setProgressValue(m_fakeFutureInterface->progressValue()
+ m_currentConfig->testCaseCount()); + m_currentConfig->testCaseCount());
if (!m_fakeFutureInterface->isCanceled()) { if (m_currentProcess && !m_fakeFutureInterface->isCanceled()) {
if (m_currentProcess->exitStatus() == QProcess::CrashExit) { if (m_currentProcess->exitStatus() == QProcess::CrashExit) {
if (m_currentOutputReader)
m_currentOutputReader->reportCrash(); m_currentOutputReader->reportCrash();
reportResult(ResultType::MessageFatal, reportResult(ResultType::MessageFatal,
tr("Test for project \"%1\" crashed.").arg(m_currentConfig->displayName()) tr("Test for project \"%1\" crashed.").arg(m_currentConfig->displayName())
+ processInformation(m_currentProcess) + rcInfo(m_currentConfig)); + processInformation(m_currentProcess) + rcInfo(m_currentConfig));
} else if (!m_currentOutputReader->hadValidOutput()) { } else if (m_currentOutputReader && !m_currentOutputReader->hadValidOutput()) {
reportResult(ResultType::MessageFatal, reportResult(ResultType::MessageFatal,
tr("Test for project \"%1\" did not produce any expected output.") tr("Test for project \"%1\" did not produce any expected output.")
.arg(m_currentConfig->displayName()) + processInformation(m_currentProcess) .arg(m_currentConfig->displayName()) + processInformation(m_currentProcess)