feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't create a temporary list of values for qDeleteAll

Browse Source 
It's enough to pass QHash as an input for qDeleteAll,
it will delete all values and won't touch keys.

Change-Id: I9b00963888ac780f74eabdf59ad02890a042a0d2
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Jarek Kobus
2020-11-16 20:13:45 +01:00
parent 0de8aab7ae
commit e97a267533
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/autotest/autotestplugin.cpp
View File

@@ -172,7 +172,7 @@ AutotestPluginPrivate::AutotestPluginPrivate()
AutotestPluginPrivate::~AutotestPluginPrivate() AutotestPluginPrivate::~AutotestPluginPrivate()
{ {
if (!s_projectSettings.isEmpty()) { if (!s_projectSettings.isEmpty()) {
qDeleteAll(s_projectSettings.values()); qDeleteAll(s_projectSettings);
s_projectSettings.clear(); s_projectSettings.clear();
} }