From e98e5cc980fd659c12085c5b2e4d83e784315f9f Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Sun, 7 Jan 2024 06:05:36 +0100
Subject: [PATCH] Android: Avoid using keys()

Instead, iterate directly over the container.

Change-Id: I722dcf811a112b1b4845dcbcd6efe78cfe3b2e49
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/android/sdkmanageroutputparser_test.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/android/sdkmanageroutputparser_test.cpp b/src/plugins/android/sdkmanageroutputparser_test.cpp
index b3967acf1e0..067b2f53056 100644
--- a/src/plugins/android/sdkmanageroutputparser_test.cpp
+++ b/src/plugins/android/sdkmanageroutputparser_test.cpp
@@ -28,7 +28,7 @@ void SdkManagerOutputParserTest::testParseMarkers_data()
     QTest::addColumn<QString>("output");
     QTest::addColumn<SdkManagerOutputParser::MarkerTag>("markerTag");
 
-    QMap<SdkManagerOutputParser::MarkerTag, QString> testData
+    const QMap<SdkManagerOutputParser::MarkerTag, QString> testData
         = {{SdkManagerOutputParser::MarkerTag::InstalledPackagesMarker, "Installed packages:"},
            {SdkManagerOutputParser::MarkerTag::AvailablePackagesMarkers, "Available Packages:"},
            {SdkManagerOutputParser::MarkerTag::AvailableUpdatesMarker, "Available Updates:"},
@@ -44,8 +44,8 @@ void SdkManagerOutputParserTest::testParseMarkers_data()
            {SdkManagerOutputParser::MarkerTag::CmdlineSdkToolsMarker, "cmdline-tools"},
            {SdkManagerOutputParser::MarkerTag::GenericToolMarker, "sources;android-32"}};
 
-    for (const SdkManagerOutputParser::MarkerTag data : testData.keys())
-        QTest::newRow(testData.value(data).toLatin1().constData()) << testData.value(data) << data;
+    for (auto it = testData.begin(); it != testData.end(); ++it)
+        QTest::newRow(it->toLatin1().constData()) << *it << it.key();
 
     QTest::newRow("Installed packages")
         << "Installed packages:" << SdkManagerOutputParser::MarkerTag::InstalledPackagesMarker;