feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove a couple of "setAutoRaise(true)" for toolbar buttons

Browse Source 
Most of the QToolButtons in the toolbars don't set autoRaise, and they
are fine. I assume that those who do set it, just do it for because that
line was copy/pasted so often.

Change-Id: I71341ddbd26a586d34713661ec538b37033685e5
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Alessandro Portale
2019-04-23 18:32:56 +02:00
parent 4ebcf52de9
commit e9cf8a4e3e
8 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/serialterminal/serialoutputpane.cpp
View File

@@ -352,7 +352,6 @@ void SerialOutputPane::createToolButtons()
m_connectButton = new QToolButton;
m_connectButton->setIcon(Utils::Icons::RUN_SMALL_TOOLBAR.icon());
m_connectButton->setToolTip(tr("Connect"));
m_connectButton->setAutoRaise(true);
m_connectButton->setEnabled(false);
connect(m_connectButton, &QToolButton::clicked,
this, &SerialOutputPane::connectControl);
@@ -361,7 +360,6 @@ void SerialOutputPane::createToolButtons()
m_disconnectButton = new QToolButton;
m_disconnectButton->setIcon(Utils::Icons::STOP_SMALL_TOOLBAR.icon());
m_disconnectButton->setToolTip(tr("Disconnect"));
m_disconnectButton->setAutoRaise(true);
m_disconnectButton->setEnabled(false);
connect(m_disconnectButton, &QToolButton::clicked,
@@ -371,7 +369,6 @@ void SerialOutputPane::createToolButtons()
m_resetButton = new QToolButton;
m_resetButton->setIcon(Utils::Icons::RELOAD.icon());
m_resetButton->setToolTip(tr("Reset Board"));
m_resetButton->setAutoRaise(true);
m_resetButton->setEnabled(false);
connect(m_resetButton, &QToolButton::clicked,
@@ -381,7 +378,6 @@ void SerialOutputPane::createToolButtons()
m_newButton = new QToolButton;
m_newButton->setIcon(Utils::Icons::PLUS_TOOLBAR.icon());
m_newButton->setToolTip(tr("Add New Terminal"));
m_newButton->setAutoRaise(true);
m_newButton->setEnabled(true);
connect(m_newButton, &QToolButton::clicked,