forked from qt-creator/qt-creator
Remove unused QObject parent arguments on options pages
In the new plugin setup scheme they are data members of the plugin pimpl and never use the parent. Change-Id: I28fe150393e8159064dcfbd113ce0320af50fd58 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -35,8 +35,7 @@
|
||||
namespace Ios {
|
||||
namespace Internal {
|
||||
|
||||
IosSettingsPage::IosSettingsPage(QObject *parent)
|
||||
: Core::IOptionsPage(parent)
|
||||
IosSettingsPage::IosSettingsPage()
|
||||
{
|
||||
setId(Constants::IOS_SETTINGS_ID);
|
||||
setDisplayName(tr("iOS"));
|
||||
|
||||
@@ -39,7 +39,7 @@ class IosSettingsPage : public Core::IOptionsPage
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
explicit IosSettingsPage(QObject *parent = nullptr);
|
||||
IosSettingsPage();
|
||||
|
||||
QWidget *widget() override;
|
||||
void apply() override;
|
||||
|
||||
@@ -62,9 +62,8 @@ static void onSimOperation(const SimulatorInfo &simInfo, SimulatorOperationDialo
|
||||
dlg->addMessage(simInfo, response, contextStr);
|
||||
}
|
||||
|
||||
IosSettingsWidget::IosSettingsWidget(QWidget *parent)
|
||||
: QWidget(parent),
|
||||
m_ui(new Ui::IosSettingsWidget),
|
||||
IosSettingsWidget::IosSettingsWidget()
|
||||
: m_ui(new Ui::IosSettingsWidget),
|
||||
m_simControl(new SimulatorControl(this))
|
||||
{
|
||||
m_ui->setupUi(this);
|
||||
|
||||
@@ -33,15 +33,13 @@ namespace Ios {
|
||||
namespace Internal {
|
||||
|
||||
namespace Ui { class IosSettingsWidget; }
|
||||
class SimulatorInfoModel;
|
||||
using SimulatorInfoList = QList<SimulatorInfo>;
|
||||
|
||||
class IosSettingsWidget : public QWidget
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
IosSettingsWidget(QWidget *parent = nullptr);
|
||||
IosSettingsWidget();
|
||||
~IosSettingsWidget() override;
|
||||
|
||||
void saveSettings();
|
||||
|
||||
Reference in New Issue
Block a user