forked from qt-creator/qt-creator
Remove unused QObject parent arguments on options pages
In the new plugin setup scheme they are data members of the plugin pimpl and never use the parent. Change-Id: I28fe150393e8159064dcfbd113ce0320af50fd58 Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
@@ -52,7 +52,7 @@ class QbsProfilesSettingsWidget : public QWidget
|
||||
{
|
||||
Q_OBJECT
|
||||
public:
|
||||
QbsProfilesSettingsWidget(QWidget *parent = nullptr);
|
||||
QbsProfilesSettingsWidget();
|
||||
|
||||
void apply();
|
||||
|
||||
@@ -64,10 +64,8 @@ private:
|
||||
qbs::SettingsModel m_model;
|
||||
};
|
||||
|
||||
QbsProfilesSettingsPage::QbsProfilesSettingsPage(QObject *parent)
|
||||
: Core::IOptionsPage(parent)
|
||||
, m_useQtcSettingsDirPersistent(QbsProjectManagerSettings::useCreatorSettingsDirForQbs())
|
||||
|
||||
QbsProfilesSettingsPage::QbsProfilesSettingsPage()
|
||||
: m_useQtcSettingsDirPersistent(QbsProjectManagerSettings::useCreatorSettingsDirForQbs())
|
||||
{
|
||||
setId("Y.QbsProfiles");
|
||||
setDisplayName(QCoreApplication::translate("QbsProjectManager", "Qbs"));
|
||||
@@ -97,9 +95,8 @@ void QbsProfilesSettingsPage::finish()
|
||||
}
|
||||
|
||||
|
||||
QbsProfilesSettingsWidget::QbsProfilesSettingsWidget(QWidget *parent)
|
||||
: QWidget(parent)
|
||||
, m_model(QbsProjectManagerSettings::qbsSettingsBaseDir(), qbs::Settings::UserScope)
|
||||
QbsProfilesSettingsWidget::QbsProfilesSettingsWidget()
|
||||
: m_model(QbsProjectManagerSettings::qbsSettingsBaseDir(), qbs::Settings::UserScope)
|
||||
{
|
||||
m_model.setEditable(false);
|
||||
m_ui.setupUi(this);
|
||||
|
||||
@@ -34,7 +34,7 @@ class QbsProfilesSettingsWidget;
|
||||
class QbsProfilesSettingsPage : public Core::IOptionsPage
|
||||
{
|
||||
public:
|
||||
QbsProfilesSettingsPage(QObject *parent = nullptr);
|
||||
QbsProfilesSettingsPage();
|
||||
|
||||
private:
|
||||
QWidget *widget() override;
|
||||
|
||||
@@ -90,7 +90,7 @@ public:
|
||||
QbsBuildStepFactory buildStepFactory;
|
||||
QbsCleanStepFactory cleanStepFactory;
|
||||
QbsInstallStepFactory installStepFactory;
|
||||
QbsProfilesSettingsPage profilesSetttingsPage;
|
||||
QbsProfilesSettingsPage profilesSettingsPage;
|
||||
QbsKitAspect qbsKitAspect;
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user