IVersionControl: Change vcsAnnotate return type to void

All implementations return true unconditionally, and the return
value is never read anyway.

+ Remove superfluous function with the same name in Perforce.

Change-Id: I83f361ec7fd8be3177cb4be52e6276e295cd4279
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Orgad Shaneh
2020-06-17 23:34:16 +03:00
committed by Orgad Shaneh
parent 55f3764d08
commit e9df7825fa
8 changed files with 17 additions and 33 deletions

View File

@@ -199,7 +199,7 @@ public:
/*!
* Display annotation for a file and scroll to line
*/
virtual bool vcsAnnotate(const QString &file, int line) = 0;
virtual void vcsAnnotate(const QString &file, int line) = 0;
/*!
* Display text for Open operation
@@ -296,7 +296,7 @@ public:
bool vcsDelete(const QString &) override { return false; }
bool vcsMove(const QString &, const QString &) override { return false; }
bool vcsCreateRepository(const QString &) override { return false; }
bool vcsAnnotate(const QString &, int) override { return false; }
void vcsAnnotate(const QString &, int) override {}
private:
Id m_id;