From e9ef83f4c672cdd9cc40217db201f44b3bb892cb Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 8 Dec 2020 11:19:38 +0100 Subject: [PATCH] Don't call non-const method on temporary container ...as it may detach. Fix the following clazy warning: Don't call QList::first() on temporary [clazy-detaching-temporary]. Change-Id: I667c122c42ccfc1344508154466d9c1dc6ae6166 Reviewed-by: hjk --- src/plugins/perfprofiler/perfprofilertool.cpp | 2 +- .../components/transitioneditor/transitioneditorwidget.cpp | 2 +- src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/perfprofiler/perfprofilertool.cpp b/src/plugins/perfprofiler/perfprofilertool.cpp index 9f949d331ef..ee4381f427a 100644 --- a/src/plugins/perfprofiler/perfprofilertool.cpp +++ b/src/plugins/perfprofiler/perfprofilertool.cpp @@ -548,7 +548,7 @@ void PerfProfilerTool::gotoSourceLocation(QString filePath, int lineNumber, int QFileInfo fi(filePath); if (!fi.isAbsolute() || !fi.exists() || !fi.isReadable()) { - fi.setFile(m_fileFinder.findFile(filePath).first().toString()); + fi.setFile(m_fileFinder.findFile(filePath).constFirst().toString()); if (!fi.exists() || !fi.isReadable()) return; } diff --git a/src/plugins/qmldesigner/components/transitioneditor/transitioneditorwidget.cpp b/src/plugins/qmldesigner/components/transitioneditor/transitioneditorwidget.cpp index b2cb67c988d..a62fe1fd8ca 100644 --- a/src/plugins/qmldesigner/components/transitioneditor/transitioneditorwidget.cpp +++ b/src/plugins/qmldesigner/components/transitioneditor/transitioneditorwidget.cpp @@ -329,7 +329,7 @@ void TransitionEditorWidget::init() if (root.isValid() && root.hasProperty("transitions")) { NodeAbstractProperty transitions = root.nodeAbstractProperty("transitions"); if (transitions.isValid()) - transition = transitions.directSubNodes().first(); + transition = transitions.directSubNodes().constFirst(); } m_graphicsScene->setTransition(transition); diff --git a/src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp b/src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp index 3be8aff25b3..f12e6f97786 100644 --- a/src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp @@ -118,7 +118,7 @@ void QmlProfilerDetailsRewriter::requestDetailsForLocation(int typeId, QString QmlProfilerDetailsRewriter::getLocalFile(const QString &remoteFile) { - const QString localFile = m_projectFinder.findFile(remoteFile).first().toString(); + const QString localFile = m_projectFinder.findFile(remoteFile).constFirst().toString(); const QFileInfo fileInfo(localFile); if (!fileInfo.exists() || !fileInfo.isReadable()) return QString();