From ea1b35584de0d1825c8baba44e21206ef8782edb Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Fri, 1 Jul 2022 16:42:37 +0200
Subject: [PATCH] RemoteLinux: Streamline RsyncDeployStep interface

Change-Id: I5b5945758d4d188887e8724c09272f0fd9867c60
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
---
 src/plugins/remotelinux/rsyncdeploystep.cpp | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/plugins/remotelinux/rsyncdeploystep.cpp b/src/plugins/remotelinux/rsyncdeploystep.cpp
index 02ec3e1919e..363ed7f7189 100644
--- a/src/plugins/remotelinux/rsyncdeploystep.cpp
+++ b/src/plugins/remotelinux/rsyncdeploystep.cpp
@@ -5,6 +5,7 @@
 
 #include "abstractremotelinuxdeploystep.h"
 #include "abstractremotelinuxdeployservice.h"
+#include "abstractremotelinuxdeploystep.h"
 #include "remotelinux_constants.h"
 #include "remotelinuxtr.h"
 
@@ -76,7 +77,6 @@ private:
     void doDeploy() override;
     void stopDeployment() override { setFinished(); };
 
-    void filterFiles() const;
     void createRemoteDirectories();
     void deployFiles();
     void setFinished();
@@ -96,7 +96,8 @@ void RsyncDeployService::setDeployableFiles(const QList<DeployableFile> &files)
 
 bool RsyncDeployService::isDeploymentNecessary() const
 {
-    filterFiles();
+    if (m_ignoreMissingFiles)
+        Utils::erase(m_files, [](const FileToTransfer &file) { return !file.m_source.exists(); });
     return !m_files.empty();
 }
 
@@ -105,14 +106,6 @@ void RsyncDeployService::doDeploy()
     createRemoteDirectories();
 }
 
-void RsyncDeployService::filterFiles() const
-{
-    if (!m_ignoreMissingFiles)
-        return;
-
-    Utils::erase(m_files, [](const FileToTransfer &file) { return !file.m_source.exists(); });
-}
-
 void RsyncDeployService::createRemoteDirectories()
 {
     QStringList remoteDirs;