feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AbstractProcessStep: Merge finish() with processFinished()

Browse Source 
Change-Id: Ied15ec3ee9d3bcc80b03b2589d101c65f2fd062a
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-12-02 17:37:10 +01:00
parent 6832200313
commit ea35ed9ffe
12 changed files with 42 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -682,10 +682,10 @@ QString CMakeBuildStep::baseEnvironmentText() const
return Tr::tr("System Environment");
}
void CMakeBuildStep::processFinished(bool success)
void CMakeBuildStep::finish(ProcessResult result)
{
Q_UNUSED(success)
emit progress(100, {});
AbstractProcessStep::finish(result);
}
// CMakeBuildStepFactory

2
src/plugins/cmakeprojectmanager/cmakebuildstep.h
View File

@@ -77,7 +77,7 @@ signals:
private:
Utils::CommandLine cmakeCommand() const;
void processFinished(bool success) override;
void finish(Utils::ProcessResult result) override;
bool fromMap(const QVariantMap &map) override;
bool init() override;

7
src/plugins/cmakeprojectmanager/cmakeinstallstep.cpp
View File

@@ -36,7 +36,7 @@ public:
private:
CommandLine cmakeCommand() const;
void processFinished(bool success) override;
void finish(ProcessResult result) override;
void setupOutputFormatter(OutputFormatter *formatter) override;
QWidget *createConfigWidget() override;
@@ -88,12 +88,11 @@ CommandLine CMakeInstallStep::cmakeCommand() const
return cmd;
}
void CMakeInstallStep::processFinished(bool success)
void CMakeInstallStep::finish(ProcessResult result)
{
Q_UNUSED(success)
emit progress(100, {});
AbstractProcessStep::finish(result);
}
QWidget *CMakeInstallStep::createConfigWidget()
{
auto updateDetails = [this] {