feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSInspector::ClientProxy: make the QML - JS debugger actually work

Browse Source
This commit is contained in:
Olivier Goffart
2010-07-02 11:58:10 +02:00
parent 8e029e221c
commit ea6775d104
1 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/qmljsinspector/qmljsclientproxy.cpp
View File

@@ -31,6 +31,7 @@
#include "qmljsprivateapi.h" #include "qmljsprivateapi.h"
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <extensionsystem/pluginmanager.h>
#include <QUrl> #include <QUrl>
#include <QAbstractSocket> #include <QAbstractSocket>
@@ -97,12 +98,6 @@ bool ClientProxy::connectToViewer(const QString &host, quint16 port)
if (!m_conn->waitForConnected()) if (!m_conn->waitForConnected())
return false; return false;
// ### commented out as the code resulted in asserts
// QTC_ASSERT(m_debuggerRunControl, return false);
// Debugger::Internal::QmlEngine *engine = qobject_cast<Debugger::Internal::QmlEngine *>(m_debuggerRunControl->engine());
// QTC_ASSERT(engine, return false);
// (void) new DebuggerClient(m_conn, engine);
return true; return true;
} }
@@ -162,6 +157,25 @@ void ClientProxy::connectionStateChanged()
#endif #endif
} }
{
ExtensionSystem::PluginManager *pm = ExtensionSystem::PluginManager::instance();
const QList<Debugger::DebuggerRunControlFactory *> factories = pm->getObjects<Debugger::DebuggerRunControlFactory>();
ProjectExplorer::RunControl *runControl = 0;
Debugger::DebuggerStartParameters sp;
sp.startMode = Debugger::StartExternal;
sp.executable = "qmlviewer"; //FIXME
runControl = factories.first()->create(sp);
m_debuggerRunControl = qobject_cast<Debugger::DebuggerRunControl *>(runControl);
QTC_ASSERT(m_debuggerRunControl, return );
Debugger::Internal::QmlEngine *engine = qobject_cast<Debugger::Internal::QmlEngine *>(m_debuggerRunControl->engine());
QTC_ASSERT(engine, return );
(void) new DebuggerClient(m_conn, engine);
engine->Debugger::Internal::DebuggerEngine::startDebugger(m_debuggerRunControl);
engine->startSuccessful();
}
reloadEngines(); reloadEngines();
break; break;